* [PATCH] s3c-fb: Fix mixed code and variable declaration
@ 2010-01-15 16:51 Mark Brown
2010-01-16 2:34 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2010-01-15 16:51 UTC (permalink / raw)
To: Andrew Morton, Ben Dooks; +Cc: linux-kernel, Mark Brown
Hoist osdc_data up into the variable declaration section.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/video/s3c-fb.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index e2e7afd..58e2fed 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -269,6 +269,7 @@ static int s3c_fb_set_par(struct fb_info *info)
int win_no = win->index;
u32 data;
u32 pagewidth;
+ u32 osdc_data;
int clkdiv;
dev_dbg(sfb->dev, "setting framebuffer parameters\n");
@@ -359,8 +360,6 @@ static int s3c_fb_set_par(struct fb_info *info)
data = var->xres * var->yres;
- u32 osdc_data = 0;
-
osdc_data = VIDISD14C_ALPHA1_R(0xf) |
VIDISD14C_ALPHA1_G(0xf) |
VIDISD14C_ALPHA1_B(0xf);
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s3c-fb: Fix mixed code and variable declaration
2010-01-15 16:51 [PATCH] s3c-fb: Fix mixed code and variable declaration Mark Brown
@ 2010-01-16 2:34 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2010-01-16 2:34 UTC (permalink / raw)
To: Mark Brown; +Cc: Andrew Morton, Ben Dooks, linux-kernel
On Fri, Jan 15, 2010 at 04:51:26PM +0000, Mark Brown wrote:
> Hoist osdc_data up into the variable declaration section.
>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/video/s3c-fb.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index e2e7afd..58e2fed 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -269,6 +269,7 @@ static int s3c_fb_set_par(struct fb_info *info)
> int win_no = win->index;
> u32 data;
> u32 pagewidth;
> + u32 osdc_data;
> int clkdiv;
>
> dev_dbg(sfb->dev, "setting framebuffer parameters\n");
> @@ -359,8 +360,6 @@ static int s3c_fb_set_par(struct fb_info *info)
>
> data = var->xres * var->yres;
>
> - u32 osdc_data = 0;
> -
> osdc_data = VIDISD14C_ALPHA1_R(0xf) |
> VIDISD14C_ALPHA1_G(0xf) |
> VIDISD14C_ALPHA1_B(0xf);
> --
> 1.6.6
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-16 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-15 16:51 [PATCH] s3c-fb: Fix mixed code and variable declaration Mark Brown
2010-01-16 2:34 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox