* [PATCH] console/vgacon.c: mark file-local symbol static.
@ 2010-01-16 22:52 Thiago Farina
2010-01-17 1:18 ` Matthew Garrett
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Farina @ 2010-01-16 22:52 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Morton, Matthew Garrett, H. Peter Anvin, Uwe Geuder,
Pekka Enberg
warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
drivers/video/console/vgacon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index cc4bbbe..19e474d 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -112,7 +112,7 @@ static int vga_video_font_height;
static int vga_scan_lines __read_mostly;
static unsigned int vga_rolled_over;
-int vgacon_text_mode_force = 0;
+static int vgacon_text_mode_force = 0;
bool vgacon_text_force(void)
{
--
1.6.6.103.g699d2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] console/vgacon.c: mark file-local symbol static.
2010-01-16 22:52 [PATCH] console/vgacon.c: mark file-local symbol static Thiago Farina
@ 2010-01-17 1:18 ` Matthew Garrett
2010-01-17 13:36 ` Thiago Farina
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Garrett @ 2010-01-17 1:18 UTC (permalink / raw)
To: Thiago Farina
Cc: linux-kernel, Andrew Morton, H. Peter Anvin, Uwe Geuder,
Pekka Enberg
On Sat, Jan 16, 2010 at 05:52:13PM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> drivers/video/console/vgacon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index cc4bbbe..19e474d 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -112,7 +112,7 @@ static int vga_video_font_height;
> static int vga_scan_lines __read_mostly;
> static unsigned int vga_rolled_over;
>
> -int vgacon_text_mode_force = 0;
> +static int vgacon_text_mode_force = 0;
Should probably lose the assignment while we're at it?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] console/vgacon.c: mark file-local symbol static.
2010-01-17 1:18 ` Matthew Garrett
@ 2010-01-17 13:36 ` Thiago Farina
2010-01-17 19:31 ` Matthew Garrett
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Farina @ 2010-01-17 13:36 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Morton, Matthew Garrett, H. Peter Anvin, Uwe Geuder,
Pekka Enberg
warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
drivers/video/console/vgacon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index cc4bbbe..182dd6f 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -112,7 +112,7 @@ static int vga_video_font_height;
static int vga_scan_lines __read_mostly;
static unsigned int vga_rolled_over;
-int vgacon_text_mode_force = 0;
+static int vgacon_text_mode_force;
bool vgacon_text_force(void)
{
--
1.6.6.103.g699d2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] console/vgacon.c: mark file-local symbol static.
2010-01-17 13:36 ` Thiago Farina
@ 2010-01-17 19:31 ` Matthew Garrett
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Garrett @ 2010-01-17 19:31 UTC (permalink / raw)
To: Thiago Farina
Cc: linux-kernel, Andrew Morton, H. Peter Anvin, Uwe Geuder,
Pekka Enberg
On Sun, Jan 17, 2010 at 08:36:36AM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
Acked-by: Matthew Garrett <mjg@redhat.com>
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-17 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-16 22:52 [PATCH] console/vgacon.c: mark file-local symbol static Thiago Farina
2010-01-17 1:18 ` Matthew Garrett
2010-01-17 13:36 ` Thiago Farina
2010-01-17 19:31 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox