Re: [RFC][PATCH] PM: Force GFP_NOIO during suspend/resume (was: Re: [linux-pm] Memory allocations in .suspend became very unreliable)

Oliver Neukum
2010-01-17T01:23:54Z

Am Sonntag, 17. Januar 2010 01:38:37 schrieb Rafael J. Wysocki:
> > Now having said that, we've been considering a change that will turn all
> > GFP_KERNEL allocations into GFP_NOIO during suspend/resume, so perhaps I'll
> > prepare a patch to do that and let's see what people think.
>
> If I didn't confuse anything (which is likely, because it's a bit late here
> now), the patch below should do the trick. I have only checked that it doesn't
> break compilation, so please take it with a grain of salt.
>
> Comments welcome.

I think this is a bad idea as it makes the mm subsystem behave differently
in the runtime and in the whole system cases. What's so hard about telling
people that they need to use GFP_NOIO in suspend() and resume()?

Regards
Oliver