From: Anton Blanchard <anton@samba.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Bharata B Rao <bharata@linux.vnet.ibm.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
schwidefsky@de.ibm.com, balajirrao@gmail.com,
dhaval@linux.vnet.ibm.com, tglx@linutronix.de,
kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com
Subject: Re: [PATCH] sched: cpuacct: Use bigger percpu counter batch values for stats counters
Date: Mon, 18 Jan 2010 19:21:51 +1100 [thread overview]
Message-ID: <20100118082151.GU12666@kryten> (raw)
In-Reply-To: <1263801079.4283.22.camel@laptop>
Hi Peter,
> Seems like a good idea, but isn't that batch number rather static? If
> so, computing it in some init path would save that multiply on the
> actual accounting path.
It is mostly static, but percpu_counter_batch does change with hotplug
operations. Adding a hotplug notifier felt like a lot of work but I was
worried we have issues if we didn't scale with hotplug add operations.
Anton
next prev parent reply other threads:[~2010-01-18 8:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 9:59 [PATCH v3] cpuacct: VIRT_CPU_ACCOUNTING don't prevent percpu cputime count KOSAKI Motohiro
2009-05-07 10:50 ` Ingo Molnar
2009-05-09 9:26 ` KOSAKI Motohiro
2009-05-09 9:38 ` Peter Zijlstra
2009-05-09 9:52 ` KOSAKI Motohiro
2009-05-09 10:14 ` KOSAKI Motohiro
2009-05-11 12:33 ` [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters tip-bot for KOSAKI Motohiro
2009-05-11 12:36 ` tip-bot for KOSAKI Motohiro
2009-05-11 15:07 ` Ingo Molnar
2009-05-12 10:01 ` KOSAKI Motohiro
2009-05-12 10:02 ` Peter Zijlstra
2009-05-12 10:06 ` KOSAKI Motohiro
2009-05-12 10:22 ` KOSAKI Motohiro
2009-05-12 10:27 ` Ingo Molnar
2009-05-12 10:42 ` KOSAKI Motohiro
2009-05-12 10:10 ` Balbir Singh
2009-05-12 10:13 ` KOSAKI Motohiro
2009-05-12 10:24 ` Balbir Singh
2009-05-12 10:29 ` Ingo Molnar
2009-05-12 10:44 ` KOSAKI Motohiro
2009-05-12 13:28 ` Ingo Molnar
2009-05-12 13:40 ` KOSAKI Motohiro
2009-05-12 13:42 ` Ingo Molnar
2009-07-16 8:10 ` Bharata B Rao
2009-07-16 8:39 ` Anton Blanchard
2009-08-20 5:10 ` Anton Blanchard
2009-08-20 5:16 ` KAMEZAWA Hiroyuki
2009-08-20 5:26 ` Balbir Singh
2009-08-20 5:52 ` Peter Zijlstra
2009-08-20 6:05 ` Anton Blanchard
2009-08-20 6:10 ` KAMEZAWA Hiroyuki
2009-08-20 6:24 ` Anton Blanchard
2009-08-20 8:41 ` [PATCH] better align percpu counter (Was " KAMEZAWA Hiroyuki
2009-08-20 10:04 ` Ingo Molnar
2009-08-21 2:20 ` KAMEZAWA Hiroyuki
2009-08-21 11:29 ` Ingo Molnar
2009-08-21 3:56 ` KAMEZAWA Hiroyuki
2009-08-20 11:46 ` Balbir Singh
2009-08-21 6:21 ` KAMEZAWA Hiroyuki
2010-01-18 4:41 ` [PATCH] " Anton Blanchard
2010-01-18 4:55 ` KOSAKI Motohiro
2010-01-18 7:51 ` Peter Zijlstra
2010-01-18 8:21 ` Anton Blanchard [this message]
2010-01-18 8:34 ` Peter Zijlstra
2010-01-18 8:35 ` Balbir Singh
2010-01-18 9:42 ` Martin Schwidefsky
2010-01-18 9:55 ` Anton Blanchard
2010-01-18 11:00 ` Balbir Singh
2010-01-21 15:25 ` Balbir Singh
2010-01-21 15:36 ` Peter Zijlstra
2010-01-25 23:14 ` Andrew Morton
2010-01-25 23:44 ` KOSAKI Motohiro
2010-01-26 6:17 ` Balbir Singh
2010-01-26 6:35 ` Andrew Morton
2010-01-26 8:07 ` Anton Blanchard
2010-01-27 13:15 ` [tip:sched/urgent] " tip-bot for Anton Blanchard
2010-01-27 13:34 ` Balbir Singh
2010-01-27 21:22 ` Andrew Morton
2010-01-27 21:43 ` Peter Zijlstra
2010-01-28 12:48 ` [PATCH 1/2] percpu_counter: Make __percpu_counter_add an inline function on UP Anton Blanchard
2010-01-28 12:52 ` [PATCH 2/2] sched: cpuacct: Use bigger percpu counter batch values for stats counters Anton Blanchard
2010-01-28 5:21 ` [tip:sched/urgent] " Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118082151.GU12666@kryten \
--to=anton@samba.org \
--cc=akpm@linux-foundation.org \
--cc=balajirrao@gmail.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox