Re: [PATCH 1/2] kvm: fix spurious interrupt with irqfd

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jan 19, 2010 at 03:23:25PM +0100, Jan Kiszka wrote:
> Michael S. Tsirkin wrote:
> >>>> I just wonder how broad
> >>>> the impact of a broken or non-existent eventfd subsystem for kvm-kmod
> >>>> is. Any thoughts welcome.
> >>> How do you handle kernels that don't export eventfd_ctx_fileget?
> >> Now that you mention it: not yet properly. So far we pass the file
> >> struct as pseudo eventfd_ctx around on < 2.6.31. But now that I peek
> >> into the struct in kvm_eventfd_ctx_remove_wait_queue, this should should
> >> crash. Guess I need to look up that module the same way as I acquire
> >> __wake_up_locked[_key].
> > 
> > This won't work that well: eventfd in upstream
> > sends us POLLHUP so we can close the structure,
> > in old kernels it doesn't so kernel will crash
> > when we try to reference the structure later.
> > 
> 
> OK, so any host kernel < 2.6.31 will never work for us. Mmh, then I
> could only close the gap 2.6.31..2.6.33. vhost will show up in 33...
> Will that version already be worth any eventfd wrapping?
> 
> Jan

I asked Avi to send a patch upstream into 2.6.32.X fixing spurious
interrupts there. 2.6.31-stable is closed unfortunately, so we won't be
able to support it.  Disable eventfd there?

> -- 
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux