From: Yong Wang <yong.y.wang@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org, austin.zhang@intel.com
Subject: [PATCH -tip] perf report: Fix segmentation fault when running with '-g none'
Date: Fri, 22 Jan 2010 09:47:50 +0800 [thread overview]
Message-ID: <20100122014750.GA4111@ywang-moblin2.bj.intel.com> (raw)
Segmentation fault occurs when running perf report with '-g none':
Starting program: /root/perf report -g none
Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? ()
(gdb) bt
#0 0x00000000 in ?? ()
#1 0x0808fbb9 in perf_session__insert_output_hist_entry (
min_callchain_hits=<value optimized out>, he=<value optimized out>,
root=<value optimized out>) at util/hist.c:169
#2 perf_session__output_resort (min_callchain_hits=<value optimized out>,
he=<value optimized out>, root=<value optimized out>) at util/hist.c:204
#3 0x080575e9 in __cmd_report () at builtin-report.c:228
#4 cmd_report () at builtin-report.c:385
#5 0x0804b528 in run_builtin (p=0x8146b88, argc=3, argv=0xbffff818)
at perf.c:263
#6 0x0804bd0b in handle_internal_command (argv=<value optimized out>,
argc=<value optimized out>) at perf.c:328
#7 run_argv (argv=<value optimized out>, argc=<value optimized out>)
at perf.c:372
#8 main (argv=<value optimized out>, argc=<value optimized out>) at perf.c:456
Reported-by: Austin Zhang <austin.zhang@intel.com>
Signed-off-by: Yong Wang <yong.y.wang@intel.com>
---
tools/perfbuiltin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 4c3d699..cfc655d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -279,7 +279,7 @@ parse_callchain_opt(const struct option *opt __used, const char *arg,
else if (!strncmp(tok, "none", strlen(arg))) {
callchain_param.mode = CHAIN_NONE;
- symbol_conf.use_callchain = true;
+ symbol_conf.use_callchain = false;
return 0;
}
next reply other threads:[~2010-01-22 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 1:47 Yong Wang [this message]
2010-01-27 13:16 ` [tip:perf/urgent] perf report: Fix segmentation fault when running with '-g none' tip-bot for Yong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122014750.GA4111@ywang-moblin2.bj.intel.com \
--to=yong.y.wang@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=austin.zhang@intel.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox