From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915Ab0AVEUx (ORCPT ); Thu, 21 Jan 2010 23:20:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751466Ab0AVEUw (ORCPT ); Thu, 21 Jan 2010 23:20:52 -0500 Received: from mga11.intel.com ([192.55.52.93]:34237 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394Ab0AVEUw (ORCPT ); Thu, 21 Jan 2010 23:20:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.49,321,1262592000"; d="scan'208";a="766352045" Date: Fri, 22 Jan 2010 12:20:46 +0800 From: Wu Fengguang To: KAMEZAWA Hiroyuki Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Chen Liqin , Lennox Wu , Ralf Baechle , =?utf-8?Q?Am=C3=A9rico?= Wang , "linux-mips@linux-mips.org" , Yinghai Lu , "x86@kernel.org" , LKML , Andi Kleen , "Zheng, Shaohui" Subject: [PATCH 1/3 v3] resources: introduce generic page_is_ram() Message-ID: <20100122042046.GA24258@localhost> References: <20100122032102.137106635@intel.com> <20100122033004.193166010@intel.com> <20100122131017.544dd91b.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100122131017.544dd91b.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2010 at 06:10:17AM +0200, KAMEZAWA Hiroyuki wrote: > On Fri, 22 Jan 2010 11:21:03 +0800 > Wu Fengguang wrote: > > > It's based on walk_system_ram_range(), for archs that don't have > > their own page_is_ram(). > > > > The static verions in MIPS and SCORE are also made global. > > > > CC: Chen Liqin > > CC: Lennox Wu > > CC: Ralf Baechle > > CC: Am辿rico Wang > > CC: linux-mips@linux-mips.org > > CC: KAMEZAWA Hiroyuki > > CC: Yinghai Lu > > Signed-off-by: Wu Fengguang > > Reviewed-by: KAMEZAWA Hiroyuki > > Maybe adding comment like this is good for reviewers.. > > "This page_is_ram() returns true if specified address is registered > as System RAM in io_resource list." > > AFAIK, this "System RAM" information has been used for kdump to grab valid > memory area and seems good for the kernel itself. Thanks! Patch updated as follows. --- resources: introduce generic page_is_ram() It's based on walk_system_ram_range(), for archs that don't have their own page_is_ram(). The static verions in MIPS and SCORE are also made global. v3: add comment (KAMEZAWA Hiroyuki) v2: add PAGE_IS_RAM macro (Américo Wang) CC: Chen Liqin CC: Lennox Wu CC: Ralf Baechle CC: Américo Wang CC: linux-mips@linux-mips.org CC: Yinghai Lu Reviewed-by: KAMEZAWA Hiroyuki Signed-off-by: Wu Fengguang --- arch/mips/mm/init.c | 2 +- arch/score/mm/init.c | 2 +- include/linux/ioport.h | 2 ++ kernel/resource.c | 15 +++++++++++++++ 4 files changed, 19 insertions(+), 2 deletions(-) --- linux-mm.orig/kernel/resource.c 2010-01-22 11:20:34.000000000 +0800 +++ linux-mm/kernel/resource.c 2010-01-22 12:17:50.000000000 +0800 @@ -327,6 +327,21 @@ int walk_system_ram_range(unsigned long #endif +#define PAGE_IS_RAM 24 +static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg) +{ + return PAGE_IS_RAM; +} +/* + * This generic page_is_ram() returns true if specified address is + * registered as "System RAM" in iomem_resource list. + */ +int __attribute__((weak)) page_is_ram(unsigned long pfn) +{ + return PAGE_IS_RAM == walk_system_ram_range(pfn, 1, NULL, __is_ram); +} +#undef PAGE_IS_RAM + /* * Find empty slot in the resource tree given range and alignment. */ --- linux-mm.orig/include/linux/ioport.h 2010-01-22 11:20:34.000000000 +0800 +++ linux-mm/include/linux/ioport.h 2010-01-22 11:20:35.000000000 +0800 @@ -191,5 +191,7 @@ extern int walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages, void *arg, int (*func)(unsigned long, unsigned long, void *)); +extern int page_is_ram(unsigned long pfn); + #endif /* __ASSEMBLY__ */ #endif /* _LINUX_IOPORT_H */ --- linux-mm.orig/arch/score/mm/init.c 2010-01-22 11:20:34.000000000 +0800 +++ linux-mm/arch/score/mm/init.c 2010-01-22 11:20:35.000000000 +0800 @@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi } #ifndef CONFIG_NEED_MULTIPLE_NODES -static int __init page_is_ram(unsigned long pagenr) +int page_is_ram(unsigned long pagenr) { if (pagenr >= min_low_pfn && pagenr < max_low_pfn) return 1; --- linux-mm.orig/arch/mips/mm/init.c 2010-01-22 11:20:34.000000000 +0800 +++ linux-mm/arch/mips/mm/init.c 2010-01-22 11:20:35.000000000 +0800 @@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long } #ifndef CONFIG_NEED_MULTIPLE_NODES -static int __init page_is_ram(unsigned long pagenr) +int page_is_ram(unsigned long pagenr) { int i;