From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation
Date: Fri, 22 Jan 2010 09:22:31 -0200 [thread overview]
Message-ID: <20100122112231.GC1244@ghostprotocols.net> (raw)
In-Reply-To: <1264142379.8074.3.camel@marge.simson.net>
Em Fri, Jan 22, 2010 at 07:39:39AM +0100, Mike Galbraith escreveu:
>
> perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> LKML-Reference: <new-submission>
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 6f30fe1..af2e224 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1669,7 +1669,7 @@ do_kallsyms:
> free(kallsyms_allocated_filename);
>
> out_try_fixup:
> - if (err > 0) {
> + if (err <= 0) {
> out_fixup:
> if (kallsyms_filename == NULL)
> dso__set_long_name(self, strdup("[kernel.kallsyms]"));
Strange, we need to fixup the map only if we found some symbol, so all
the routines there return the number of symbols found or -1 for errors,
investigating perf top symbol annotation now...
- Arnaldo
next prev parent reply other threads:[~2010-01-22 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 6:39 [patch] perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation Mike Galbraith
2010-01-22 11:22 ` Arnaldo Carvalho de Melo [this message]
2010-01-22 11:45 ` Arnaldo Carvalho de Melo
2010-01-22 14:13 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122112231.GC1244@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox