public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Paul Mackerras" <paulus@samba.org>
Subject: perf regression testing. was Re: [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols
Date: Fri, 22 Jan 2010 14:51:02 -0200	[thread overview]
Message-ID: <20100122165101.GA2689@ghostprotocols.net> (raw)
In-Reply-To: <1264178608.5935.0.camel@marge.simson.net>

Em Fri, Jan 22, 2010 at 05:43:28PM +0100, Mike Galbraith escreveu:
> On Fri, 2010-01-22 at 14:35 -0200, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > Only if we parsed /proc/kallsyms (or a copy found in the buildid cache)
> > we should set the dso long name to "[kernel.kallsyms]".
> 
> Yup, works just as well as my busted one :)

yeah :-)

I'll soon start working on 'perf regtest', to start accumulating
regression tests a la 'perf bench', as these silly bugs are worrying
me...

Some will require more than one machine, and of different archs, so that
we can properly test 'perf archive' and the buildid machinery, etc. Some
need to compare what we get from kallsyms with what we get from vmlinux
of same buildid, etc.

We'll use this when developing new tools or changing the core code, and
a subset of it can also be used by users to sanity test their
environment.

If not I'll have to continue relying on you as my regression test ;-)

- Arnaldo

  reply	other threads:[~2010-01-22 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 16:35 [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols Arnaldo Carvalho de Melo
2010-01-22 16:35 ` [PATCH 2/2] perf symbols: Use the right variable to check for kallsyms in the cache Arnaldo Carvalho de Melo
2010-01-22 16:43 ` [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols Mike Galbraith
2010-01-22 16:51   ` Arnaldo Carvalho de Melo [this message]
2010-01-23  7:04     ` perf regression testing. was " Ingo Molnar
2010-01-23 15:52       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100122165101.GA2689@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox