* [PATCH] lib/dma-debug.c: mark file-local struct symbol static.
@ 2010-01-18 23:57 Thiago Farina
2010-01-22 17:01 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Thiago Farina @ 2010-01-18 23:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Joerg Roedel, Ingo Molnar, FUJITA Tomonori
warning: symbol 'filter_fops' was not declared. Should it be static?
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
lib/dma-debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 7d2f0b3..ba8b670 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -587,7 +587,7 @@ out_unlock:
return count;
}
-const struct file_operations filter_fops = {
+static const struct file_operations filter_fops = {
.read = filter_read,
.write = filter_write,
};
--
1.6.6.201.g56119
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.
2010-01-18 23:57 [PATCH] lib/dma-debug.c: mark file-local struct symbol static Thiago Farina
@ 2010-01-22 17:01 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2010-01-22 17:01 UTC (permalink / raw)
To: Thiago Farina; +Cc: linux-kernel, Ingo Molnar, FUJITA Tomonori
On Mon, Jan 18, 2010 at 06:57:33PM -0500, Thiago Farina wrote:
> warning: symbol 'filter_fops' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> lib/dma-debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 7d2f0b3..ba8b670 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -587,7 +587,7 @@ out_unlock:
> return count;
> }
>
> -const struct file_operations filter_fops = {
> +static const struct file_operations filter_fops = {
> .read = filter_read,
> .write = filter_write,
> };
Applied to dma-debug/fixes. Thanks.
Joerg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-22 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-18 23:57 [PATCH] lib/dma-debug.c: mark file-local struct symbol static Thiago Farina
2010-01-22 17:01 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox