From: Greg KH <gregkh@suse.de>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
stable@kernel.org, Rohan Hart <rohan.hart17@gmail.com>,
Ryan May <rmay31@gmail.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
stable-review@kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [Stable-review] [25/29] USB: fix usbstorage for 2770:915d delivers no FAT
Date: Fri, 22 Jan 2010 22:05:28 -0800 [thread overview]
Message-ID: <20100123060528.GA14114@suse.de> (raw)
In-Reply-To: <1264214626.373.21.camel@localhost>
On Sat, Jan 23, 2010 at 02:43:46AM +0000, Ben Hutchings wrote:
> On Fri, 2010-01-22 at 16:10 -0800, Greg KH wrote:
> > 2.6.32-stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > From: Ryan May <rmay31@gmail.com>
> >
> > commit 10d2cdb6102669279bee2d9a00a22431b74583d5 upstream.
> >
> > Resolves kernel.org bug 14914.
> >
> > Remove entry for 2770:915d (usb digital camera with mass storage
> > support) from unusual_devs.h. The fix triggered by the entry causes
> > the file system on the camera to be completely inaccessible (no
> > partition table, the device is not mountable).
> >
> > The patch works, but let me clarify a few things about it. All the
> > patch does is remove the entry for this device from the
> > drivers/usb/storage/unusual_devs.h, which is supposed to help with a
> > problem with the device's reported size (I think). I'm pretty sure it
> > was originally added for a reason, so I'm not sure removing it won't
> > cause other problems to reappear. Also, I should note that this
> > unusual_devs.h entry was present (and activating workarounds) in
> > 2.6.29, but in that version everything works fine. Starting with
> > 2.6.30, things no longer work.
> [...]
>
> It doesn't sound like this bug or fix are sufficiently well understood
> yet to be suitable for a stable update. The bug report is currently
> marked as invalid!
It was marked that way as we couldn't take a patch through a bug report.
The email thread for it said it solved the problem, and I have had a
number of other users report that it solves their problem as well.
So I do think it needs to remain, unless someone has a report to the
contrary? And if so, I'll be glad to take it out of the main tree, and
then take that back to the -stable tree.
thanks,
greg k-h
next prev parent reply other threads:[~2010-01-23 6:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 0:11 [00/29] 2.6.32.6 stable review Greg KH
2010-01-23 0:09 ` [01/29] x86, msr/cpuid: Register enough minors for the MSR and CPUID drivers Greg KH
2010-01-23 0:09 ` [02/29] V4L/DVB (13900): gspca - sunplus: Fix bridge exchanges Greg KH
2010-01-23 0:09 ` [03/29] Staging: asus_oled: fix oops in 2.6.32.2 Greg KH
2010-01-23 0:09 ` [04/29] Staging: hv: fix smp problems in the hyperv core code Greg KH
2010-01-23 0:09 ` [05/29] tty: fix race in tty_fasync Greg KH
2010-01-23 0:09 ` [06/29] ecryptfs: use after free Greg KH
2010-01-23 0:09 ` [07/29] ecryptfs: initialize private persistent file before dereferencing pointer Greg KH
2010-01-23 0:09 ` [08/29] nozomi: quick fix for the close/close bug Greg KH
2010-01-23 0:09 ` [09/29] serial: 8250_pnp: use wildcard for serial Wacom tablets Greg KH
2010-01-23 0:09 ` [10/29] usb: serial: fix memory leak in generic driver Greg KH
2010-01-23 0:09 ` [11/29] USB: fix bitmask merge error Greg KH
2010-01-23 0:09 ` [12/29] USB: Dont use GFP_KERNEL while we cannot reset a storage device Greg KH
2010-01-23 0:09 ` [13/29] USB: EHCI: fix handling of unusual interrupt intervals Greg KH
2010-01-23 0:09 ` [14/29] USB: EHCI & UHCI: fix race between root-hub suspend and port resume Greg KH
2010-01-23 0:09 ` [15/29] USB: add missing delay during remote wakeup Greg KH
2010-01-23 0:10 ` [16/29] USB: add speed values for USB 3.0 and wireless controllers Greg KH
2010-01-23 0:10 ` [17/29] ACPI: EC: Accelerate query execution Greg KH
2010-01-23 0:10 ` [18/29] ACPI: EC: Add wait for irq storm Greg KH
2010-01-23 0:10 ` [19/29] SCSI: enclosure: fix oops while iterating enclosure_status array Greg KH
2010-01-23 0:10 ` [20/29] drm/i915: Read the response after issuing DDC bus switch command Greg KH
2010-01-23 0:10 ` [21/29] drm/i915: try another possible DDC bus for the SDVO device with multiple outputs Greg KH
2010-01-23 0:10 ` [22/29] block: bdev_stack_limits wrapper Greg KH
2010-01-23 0:10 ` [23/29] DM: Fix device mapper topology stacking Greg KH
2010-01-23 0:10 ` [24/29] x86/PCI/PAT: return EINVAL for pci mmap WC request for !pat_enabled Greg KH
2010-01-23 0:10 ` [25/29] USB: fix usbstorage for 2770:915d delivers no FAT Greg KH
2010-01-23 2:43 ` [Stable-review] " Ben Hutchings
2010-01-23 6:05 ` Greg KH [this message]
2010-01-23 0:10 ` [26/29] vmalloc: remove BUG_ON due to racy counting of VM_LAZY_FREE Greg KH
2010-01-23 0:10 ` [27/29] perf timechart: Use tid not pid for COMM change Greg KH
2010-01-23 0:10 ` [28/29] perf events: Dont report side-band events on each cpu for per-task-per-cpu events Greg KH
2010-01-23 11:38 ` [Stable-review] " Stefan Bader
2010-01-23 15:33 ` Greg KH
2010-01-25 18:04 ` Greg KH
2010-01-23 0:10 ` [29/29] perf: Honour event state for aux stream data Greg KH
2010-01-24 7:21 ` [stable] [00/29] 2.6.32.6 stable review Andrew Morton
2010-01-24 16:29 ` Thomas Gleixner
2010-01-25 8:40 ` Ozan Çağlayan
2010-01-25 17:16 ` Greg KH
2010-01-25 17:39 ` Ozan Çağlayan
2010-01-25 17:46 ` Greg KH
2010-01-25 19:09 ` Greg KH
2010-01-25 18:22 ` Thomas Gleixner
2010-01-25 17:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123060528.GA14114@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmay31@gmail.com \
--cc=rohan.hart17@gmail.com \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox