From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>,
linux-kernel@vger.kernel.org,
Fr?d?ric Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: perf regression testing. was Re: [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols
Date: Sat, 23 Jan 2010 13:52:54 -0200 [thread overview]
Message-ID: <20100123155254.GB24418@ghostprotocols.net> (raw)
In-Reply-To: <20100123070451.GC15774@elte.hu>
Em Sat, Jan 23, 2010 at 08:04:51AM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>
> > Em Fri, Jan 22, 2010 at 05:43:28PM +0100, Mike Galbraith escreveu:
> > > On Fri, 2010-01-22 at 14:35 -0200, Arnaldo Carvalho de Melo wrote:
> > > > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > >
> > > > Only if we parsed /proc/kallsyms (or a copy found in the buildid cache)
> > > > we should set the dso long name to "[kernel.kallsyms]".
> > >
> > > Yup, works just as well as my busted one :)
> >
> > yeah :-)
> >
> > I'll soon start working on 'perf regtest', to start accumulating regression
> > tests a la 'perf bench', as these silly bugs are worrying me...
>
> Excellent, it's much needed!
>
> The best example i know about is KVM: they have built an impressive regression
> test suite and add testcases for new regressions all the time.
>
> The key is to have something simple to run, which developers (and
> maintainers) can run after every new perf commit or so.
Yes, that is the idea, I'm finishing the first test (/proc/kallsyms
versus what we get from a auto-located vmlinux symtab) and will submit
it soon:
[acme@doppio linux-2.6-tip]$ perf regtest
1: vmlinux symtab matches kallsyms...
Segmentation fault
[acme@doppio linux-2.6-tip]$
Not quite working yet, tho :o)
- Arnaldo
prev parent reply other threads:[~2010-01-23 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 16:35 [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols Arnaldo Carvalho de Melo
2010-01-22 16:35 ` [PATCH 2/2] perf symbols: Use the right variable to check for kallsyms in the cache Arnaldo Carvalho de Melo
2010-01-22 16:43 ` [PATCH 1/2] perf symbols: Fix inverted logic for showing kallsyms as the source of symbols Mike Galbraith
2010-01-22 16:51 ` perf regression testing. was " Arnaldo Carvalho de Melo
2010-01-23 7:04 ` Ingo Molnar
2010-01-23 15:52 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123155254.GB24418@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox