* [PATCH 1/1] kernel/exit.c: fix shadows sparse warning.
@ 2010-01-23 14:46 Thiago Farina
2010-01-25 6:10 ` KOSAKI Motohiro
2010-01-25 14:21 ` Oleg Nesterov
0 siblings, 2 replies; 3+ messages in thread
From: Thiago Farina @ 2010-01-23 14:46 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Morton, Oleg Nesterov, Ingo Molnar, Roland McGrath,
Peter Zijlstra
kernel/exit.c:1183:26: warning: symbol 'status' shadows an earlier one
kernel/exit.c:1173:21: originally declared here
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
kernel/exit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index 546774a..2e72b3f 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1180,7 +1180,7 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
if (unlikely(wo->wo_flags & WNOWAIT)) {
int exit_code = p->exit_code;
- int why, status;
+ int why;
get_task_struct(p);
read_unlock(&tasklist_lock);
--
1.6.6.1.383.g5a9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] kernel/exit.c: fix shadows sparse warning.
2010-01-23 14:46 [PATCH 1/1] kernel/exit.c: fix shadows sparse warning Thiago Farina
@ 2010-01-25 6:10 ` KOSAKI Motohiro
2010-01-25 14:21 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: KOSAKI Motohiro @ 2010-01-25 6:10 UTC (permalink / raw)
To: Thiago Farina
Cc: kosaki.motohiro, linux-kernel, Andrew Morton, Oleg Nesterov,
Ingo Molnar, Roland McGrath, Peter Zijlstra
> kernel/exit.c:1183:26: warning: symbol 'status' shadows an earlier one
> kernel/exit.c:1173:21: originally declared here
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> kernel/exit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/exit.c b/kernel/exit.c
> index 546774a..2e72b3f 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -1180,7 +1180,7 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
>
> if (unlikely(wo->wo_flags & WNOWAIT)) {
> int exit_code = p->exit_code;
> - int why, status;
> + int why;
>
> get_task_struct(p);
> read_unlock(&tasklist_lock);
Looks good to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] kernel/exit.c: fix shadows sparse warning.
2010-01-23 14:46 [PATCH 1/1] kernel/exit.c: fix shadows sparse warning Thiago Farina
2010-01-25 6:10 ` KOSAKI Motohiro
@ 2010-01-25 14:21 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2010-01-25 14:21 UTC (permalink / raw)
To: Thiago Farina
Cc: linux-kernel, Andrew Morton, Ingo Molnar, Roland McGrath,
Peter Zijlstra
On 01/23, Thiago Farina wrote:
>
> kernel/exit.c:1183:26: warning: symbol 'status' shadows an earlier one
> kernel/exit.c:1173:21: originally declared here
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> kernel/exit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/exit.c b/kernel/exit.c
> index 546774a..2e72b3f 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -1180,7 +1180,7 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
>
> if (unlikely(wo->wo_flags & WNOWAIT)) {
> int exit_code = p->exit_code;
> - int why, status;
> + int why;
Looks good, thanks.
Oleg.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-25 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 14:46 [PATCH 1/1] kernel/exit.c: fix shadows sparse warning Thiago Farina
2010-01-25 6:10 ` KOSAKI Motohiro
2010-01-25 14:21 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox