From: Frans Pop <elendil@planet.nl>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH] sched: correct whitespace in warning from cpu down task check
Date: Mon, 25 Jan 2010 14:56:34 +0100 [thread overview]
Message-ID: <201001251456.34996.elendil@planet.nl> (raw)
In-Reply-To: <201001250542.08642.elendil@planet.nl>
Due to an incorrect line break the output currently contains tabs.
Also remove trailing space.
Signed-off-by: Frans Pop <elendilplanet.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
---
The actual output that logcheck sent me looked like this:
Task events/1 (pid = 10) is on cpu 1^I^I^I^I(state = 1, flags = 84208040)
After this patch it becomes:
Task events/1 (pid = 10) is on cpu 1 (state = 1, flags = 84208040)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 08e54e7..677f253 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -154,10 +154,10 @@ static inline void check_for_tasks(int cpu)
if (task_cpu(p) == cpu && p->state == TASK_RUNNING &&
(!cputime_eq(p->utime, cputime_zero) ||
!cputime_eq(p->stime, cputime_zero)))
- printk(KERN_WARNING "Task %s (pid = %d) is on cpu %d\
- (state = %ld, flags = %x) \n",
- p->comm, task_pid_nr(p), cpu,
- p->state, p->flags);
+ printk(KERN_WARNING "Task %s (pid = %d) is on cpu %d "
+ "(state = %ld, flags = %x)\n",
+ p->comm, task_pid_nr(p), cpu,
+ p->state, p->flags);
}
write_unlock_irq(&tasklist_lock);
}
next prev parent reply other threads:[~2010-01-25 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 4:42 Warnings about tasks on CPU 1 during STR Frans Pop
2010-01-25 12:50 ` Peter Zijlstra
2010-01-25 13:52 ` Frans Pop
2010-01-25 13:56 ` Frans Pop [this message]
2010-01-27 13:16 ` [tip:sched/urgent] sched: Correct printk whitespace in warning from cpu down task check tip-bot for Frans Pop
2010-01-28 7:12 ` tip-bot for Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001251456.34996.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox