From: Philipp Reisner <philipp.reisner@linbit.com>
To: drbd-dev@lists.linbit.com
Cc: Dan Carpenter <error27@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [Drbd-dev] [patch] drbd: null dereference bug
Date: Mon, 25 Jan 2010 18:14:36 +0100 [thread overview]
Message-ID: <201001251814.37009.philipp.reisner@linbit.com> (raw)
In-Reply-To: <20100123124522.GA3061@bicker>
Am Samstag, 23. Januar 2010 13:45:22 schrieb Dan Carpenter:
> epoch is always NULL here.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> This patch has only been compile tested. Sorry. :/
>
> --- orig/drivers/block/drbd/drbd_receiver.c 2010-01-23 10:53:13.000000000
> +0300 +++ devel/drivers/block/drbd/drbd_receiver.c 2010-01-23
> 10:54:19.000000000 +0300 @@ -1224,7 +1224,7 @@ static int
> receive_Barrier(struct drbd_c
> epoch = kmalloc(sizeof(struct drbd_epoch), GFP_NOIO);
> if (!epoch) {
> dev_warn(DEV, "Allocation of an epoch failed, slowing down\n");
> - issue_flush = !test_and_set_bit(DE_BARRIER_IN_NEXT_EPOCH_ISSUED, &epoch->flags);
> + issue_flush = !test_and_set_bit(DE_BARRIER_IN_NEXT_EPOCH_ISSUED, &mdev->current_epoch->flags);
> drbd_wait_ee_list_empty(mdev, &mdev->active_ee);
> if (issue_flush) {
> rv = drbd_flush_after_epoch(mdev, mdev->current_epoch);
>
The patch is correct. It is going upstream though the DRBD tree.
See:
http://git.drbd.org/?p=linux-2.6-drbd.git;a=commit;h=d3db7b485ad7c467a61279d6a8ef51a3c83352df
-Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
prev parent reply other threads:[~2010-01-25 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 12:45 [patch] drbd: null dereference bug Dan Carpenter
2010-01-25 17:14 ` Philipp Reisner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001251814.37009.philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox