[PATCH] RE: Linux kernel 2.6.33-rc5 bug report

[PATCH] RE: Linux kernel 2.6.33-rc5 bug report

[d binderman]

Hello there,

Greg wrote:
> Care to make up a patch to fix this issue? 

Here is an untested trivial patch to fix a memory leak in Linux kernel
2.6.33-rc5 directory drivers/staging/otus

From:  David Binderman <dcb314@hotmail.com>

Fix memory leak in drivers/staging/otus

Signed-off-by: David Binderman <dcb314@hotmail.com>

---


--- drivers/staging/otus/ioctl.c.sav    2010-01-25 09:45:30.000000000 +0000
+++ drivers/staging/otus/ioctl.c        2010-01-25 09:55:56.000000000 +0000
@@ -866,15 +866,15 @@ int usbdrvwext_giwscan(struct net_device
        char *current_ev = extra;
        char *end_buf;
        int i;
-       /* struct zsBssList BssList; */
-       struct zsBssListV1 *pBssList = kmalloc(sizeof(struct zsBssListV1),
-                                                               GFP_KERNEL);
        /* BssList = wd->sta.pBssList; */
        /* zmw_get_wlan_dev(dev); */

        if (macp->DeviceOpened != 1)
                return 0;

+       /* struct zsBssList BssList; */
+       struct zsBssListV1 *pBssList = kmalloc(sizeof(struct zsBssListV1),
+                                                               GFP_KERNEL);
        if (data->length == 0)
                end_buf = extra + IW_SCAN_MAX_DATA;
        else



 		 	   		  
_________________________________________________________________
We want to hear all your funny, exciting and crazy Hotmail stories. Tell us now
http://clk.atdmt.com/UKM/go/195013117/direct/01/

Re: [PATCH] RE: Linux kernel 2.6.33-rc5 bug report

[Greg KH]

On Mon, Jan 25, 2010 at 10:16:55AM +0000, d binderman wrote:
> 
> 
> Hello there,
> 
> Greg wrote:
> > Care to make up a patch to fix this issue? 
> 
> Here is an untested trivial patch to fix a memory leak in Linux kernel
> 2.6.33-rc5 directory drivers/staging/otus
> 
> From:  David Binderman <dcb314@hotmail.com>
> 
> Fix memory leak in drivers/staging/otus
> 
> Signed-off-by: David Binderman <dcb314@hotmail.com>
> 
> ---
> 
> 
> --- drivers/staging/otus/ioctl.c.sav??? 2010-01-25 09:45:30.000000000 +0000
> +++ drivers/staging/otus/ioctl.c??????? 2010-01-25 09:55:56.000000000 +0000
> @@ -866,15 +866,15 @@ int usbdrvwext_giwscan(struct net_device
> ??????? char *current_ev = extra;
> ??????? char *end_buf;
> ??????? int i;
> -?????? /* struct zsBssList BssList; */
> -?????? struct zsBssListV1 *pBssList = kmalloc(sizeof(struct zsBssListV1),
> -?????????????????????????????????????????????????????????????? GFP_KERNEL);
> ??????? /* BssList = wd->sta.pBssList; */

Very wierd characters here, can you attach the patch instead?

thanks,

greg k-h