From: Himanshu Chauhan <hschauhan@nulltrace.org>
To: Greg KH <greg@kroah.com>
Cc: Himanshu Chauhan <himanshu@symmetricore.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Kernel Newbies <kernelnewbies@nl.linux.org>
Subject: Re: sysfs_ops show vector: size of buffer not required?
Date: Tue, 26 Jan 2010 12:01:27 +0530 [thread overview]
Message-ID: <20100126063127.GA2369@himanshu-laptop> (raw)
In-Reply-To: <20100126043646.GB32066@kroah.com>
On Mon, Jan 25, 2010 at 08:36:46PM -0800, Greg KH wrote:
> On Sun, Jan 24, 2010 at 01:11:18PM +0530, Himanshu Chauhan wrote:
> > Hi All,
> >
> > The sysfs_ops's show vector doesn't have a size of the
> > buffer given to the vector, while store on the other hand
> > has. What is the rationale behind it?
>
> If you need to check the size, you are doing something wrong.
>
> Seriously, that is the reason. A sysfs file should be a single value,
> which will never overflow the buffer.
>
I was talking in context of usb/ip's show_status. It writes a lot of data
into this buffer. Which seems to over flow the buffer. But anyways, I
will check if it can be reduced or at least be splitted into differnt
device attributes.
BTW, Greg, Did you take a look at other patches I had sent? Are are worth or
I need rework?
Regards
Himanshu
next prev parent reply other threads:[~2010-01-26 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 7:41 sysfs_ops show vector: size of buffer not required? Himanshu Chauhan
2010-01-26 4:36 ` Greg KH
2010-01-26 6:31 ` Himanshu Chauhan [this message]
2010-01-26 15:29 ` Greg KH
2010-01-26 17:10 ` Himanshu Chauhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126063127.GA2369@himanshu-laptop \
--to=hschauhan@nulltrace.org \
--cc=greg@kroah.com \
--cc=himanshu@symmetricore.com \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox