From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
dri-devel@lists.sourceforge.net, Eric Anholt <eric@anholt.net>,
airlied@linux.ie
Subject: Re: [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is used
Date: Tue, 26 Jan 2010 15:17:27 +0100 [thread overview]
Message-ID: <20100126141726.GA1437@ucw.cz> (raw)
In-Reply-To: <201001252254.37635.rjw@sisk.pl>
On Mon 2010-01-25 22:54:37, Rafael J. Wysocki wrote:
> On Monday 25 January 2010, Alan Cox wrote:
> > > > But in that case we should be able to disable the VT switch disable
> > > > path; we just have to check each driver as it's loaded.
> > >
> > > OK, what the right sequence of checks would be in that case and where to place
> > > them?
> >
> > Why are we even driving a vt switch direct from the suspend/resume
> > logic ? The problem starts there. If it was being handled off the device
> > suspend/resume method then there wouldn't be a mess to start with ?
> >
> > Start at the beginning
> >
> > - Why do we switch to arbitarily chosen 'last vt'
> > - Why isn't vt related suspend/resume handled by the device
>
> Well, that was added long ago as a workaround for some problems people
> reported (presumably). I've never looked at that before, so I can't really
> tell why someone did it this particular way.
As X drives hardware, it is/was neccessary to get control out of X and
console switch was convenient.
Note that it needs to happen with userland still active -- before
freezer.
And yes, it should be per-driver these days.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-01-26 14:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 23:55 [PATCH] PM / i915: Skip kernel VT switch during suspend/resume if KMS is used Rafael J. Wysocki
2010-01-24 0:18 ` Alan Cox
2010-01-24 19:04 ` Rafael J. Wysocki
2010-01-25 17:22 ` Eric Anholt
2010-01-25 18:35 ` Jesse Barnes
2010-01-25 18:43 ` Alan Cox
2010-01-25 18:49 ` Jesse Barnes
2010-01-25 21:17 ` Rafael J. Wysocki
2010-01-25 21:27 ` Alan Cox
2010-01-25 21:54 ` Rafael J. Wysocki
2010-01-25 22:23 ` Alan Cox
2010-01-26 14:17 ` Pavel Machek [this message]
2010-01-26 18:47 ` Rafael J. Wysocki
2010-01-26 14:58 ` Pavel Machek
2010-01-26 21:46 ` H. Peter Anvin
2010-01-26 22:08 ` Pavel Machek
2010-01-27 23:07 ` [linux-pm] " Stefan Seyfried
2010-01-31 8:54 ` Pavel Machek
2010-02-03 14:24 ` Stefan Seyfried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126141726.GA1437@ucw.cz \
--to=pavel@ucw.cz \
--cc=airlied@linux.ie \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox