Re: [PATCH] MAINTAINERS: add i2c tree for embedded platforms

[Ben Dooks <ben-linux@fluff.org>]

On Mon, Jan 25, 2010 at 11:10:55AM +0100, Jean Delvare wrote:
> On Mon, 25 Jan 2010 10:20:34 +0100, Uwe Kleine-K??nig wrote:
> > Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > ---
> > Hello,
> > 
> > I wonder if it makes sence to split the "I2C SUBSYSTEM" entry into
> > something like:
> > 
> > 	I2C SUBSYSTEM (PC drivers, core)
> > 	M:	Jean Delvare <khali@linux-fr.org>
> > 	L:	...
> > 	W:	...
> > 	T:	quilt ...
> > 	S:	...
> > 	F:	Documentation/i2c/
> > 	F:	drivers/i2c/
> > 	F:	include/linux/i2c.h
> > 	F:	include/linux/i2c-*.h
> > 
> > 	I2C SUBSYSTEM (embedded platforms)
> > 	M:	Ben Dooks <ben-linux@fluff.org>
> > 	L:	...
> > 	W:	...
> > 	T:	git ...
> > 	S:	...
> > 	F:	drivers/i2c/
> > 	F:	include/linux/i2c-*.h
> > 
> > (I'm not entirely sure about the file patterns for the 2nd entry.)
> 
> I'm not sure what value it adds, compared to having a single entry as
> we have today. scripts/get_maintainer.pl will produce the same output,
> won't it?
> 
> This script (and our minds) being directory-driven, I suspect that the
> only efficient way to split the entries would be to first move all i2c bus
> driver for embedded platforms to a separate subdirectory. I'm leaving
> it to Ben and the embedded community to decide whether they want to do
> that or not.

I'd much prefer to see just the one directory of i2c drivers, the
minor point being people silly enough to load modules by explicit path
and the second is that having all the drivers in one place makes it
easier to update them when changing something in the core...
 
> > 
> > Best regards
> > Uwe
> > 
> >  MAINTAINERS |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1858646..a1813fd 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2629,6 +2629,7 @@ M:	"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>
> >  L:	linux-i2c@vger.kernel.org
> >  W:	http://i2c.wiki.kernel.org/
> >  T:	quilt kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/
> > +T:	git git://git.fluff.org/bjdooks/linux.git
> >  S:	Maintained
> >  F:	Documentation/i2c/
> >  F:	drivers/i2c/
> 
> Yes, please!
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> -- 
> Jean Delvare
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'