Fwd: [scripts] python: change scripts to use system python instead of env

Fwd: [scripts] python: change scripts to use system python instead of env

[Don Zickus]

Doh. Typo in the To: field

----- Forwarded message from Don Zickus <dzickus@redhat.com> -----

Date: Fri, 22 Jan 2010 16:32:10 -0500
From: Don Zickus <dzickus@redhat.com>
To: lkml@vger.kernel.org
Cc: akpm@linux-foundation.org, tglx@linutronix.de, tony.luck@intel.com,
	kmcmartin@redhat.com, Don Zickus <dzickus@redhat.com>
Subject: [scripts] python: change scripts to use system python instead of env
Message-Id: <1264195930-15815-1-git-send-email-dzickus@redhat.com>

Just a small change to a couple of scripts to go from

 #!/usr/bin/env python

to

 #!/usr/bin/python

This shouldn't effect anyone, unless they don't install python there.

In preparation for python3, Fedora is doing a big push to change the scripts
to use the system python.  This allows developers to put the python3 in
their path without fear of breaking existing scripts.

Now I am pretty sure anyone using python3 for testing purposes will probably
not run any of the scripts I changed, but Fedora has this automated tool
that checks for this stuff so I thought I would try to push it upstream.

Signed-off-by: Don Zickus <dzickus@redhat.com>

--
I don't do enough python to defend this change to much other than it seems
to make sense.
---
 arch/ia64/scripts/unwcheck.py  |    2 +-
 scripts/rt-tester/rt-tester.py |    2 +-
 scripts/show_delta             |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/ia64/scripts/unwcheck.py b/arch/ia64/scripts/unwcheck.py
index c278498..2bfd941 100644
--- a/arch/ia64/scripts/unwcheck.py
+++ b/arch/ia64/scripts/unwcheck.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python
 #
 # Usage: unwcheck.py FILE
 #
diff --git a/scripts/rt-tester/rt-tester.py b/scripts/rt-tester/rt-tester.py
index 4c79660..44423b4 100644
--- a/scripts/rt-tester/rt-tester.py
+++ b/scripts/rt-tester/rt-tester.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python
 #
 # rt-mutex tester
 #
diff --git a/scripts/show_delta b/scripts/show_delta
index 48a706a..17df305 100755
--- a/scripts/show_delta
+++ b/scripts/show_delta
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python
 #
 # show_deltas: Read list of printk messages instrumented with
 # time data, and format with time deltas.
-- 
1.6.6.83.gc9a2


----- End forwarded message -----

Re: [scripts] python: change scripts to use system python instead of env

[Américo Wang]

On Wed, Jan 27, 2010 at 6:20 AM, Don Zickus <dzickus@redhat.com> wrote:
> Doh. Typo in the To: field
>
> ----- Forwarded message from Don Zickus <dzickus@redhat.com> -----
>
> Date: Fri, 22 Jan 2010 16:32:10 -0500
> From: Don Zickus <dzickus@redhat.com>
> To: lkml@vger.kernel.org
> Cc: akpm@linux-foundation.org, tglx@linutronix.de, tony.luck@intel.com,
>        kmcmartin@redhat.com, Don Zickus <dzickus@redhat.com>
> Subject: [scripts] python: change scripts to use system python instead of env
> Message-Id: <1264195930-15815-1-git-send-email-dzickus@redhat.com>
>
> Just a small change to a couple of scripts to go from
>
>  #!/usr/bin/env python
>
> to
>
>  #!/usr/bin/python
>
> This shouldn't effect anyone, unless they don't install python there.
>
> In preparation for python3, Fedora is doing a big push to change the scripts
> to use the system python.  This allows developers to put the python3 in
> their path without fear of breaking existing scripts.
>
> Now I am pretty sure anyone using python3 for testing purposes will probably
> not run any of the scripts I changed, but Fedora has this automated tool
> that checks for this stuff so I thought I would try to push it upstream.


Hmm, so python3 will be installed in /usr/local/bin?

>
> Signed-off-by: Don Zickus <dzickus@redhat.com>
>

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>


> --
> I don't do enough python to defend this change to much other than it seems
> to make sense.
> ---
>  arch/ia64/scripts/unwcheck.py  |    2 +-
>  scripts/rt-tester/rt-tester.py |    2 +-
>  scripts/show_delta             |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/ia64/scripts/unwcheck.py b/arch/ia64/scripts/unwcheck.py
> index c278498..2bfd941 100644
> --- a/arch/ia64/scripts/unwcheck.py
> +++ b/arch/ia64/scripts/unwcheck.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/python
>  #
>  # Usage: unwcheck.py FILE
>  #
> diff --git a/scripts/rt-tester/rt-tester.py b/scripts/rt-tester/rt-tester.py
> index 4c79660..44423b4 100644
> --- a/scripts/rt-tester/rt-tester.py
> +++ b/scripts/rt-tester/rt-tester.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/python
>  #
>  # rt-mutex tester
>  #
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 48a706a..17df305 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/python
>  #
>  # show_deltas: Read list of printk messages instrumented with
>  # time data, and format with time deltas.
> --
> 1.6.6.83.gc9a2
>
>
> ----- End forwarded message -----
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [scripts] python: change scripts to use system python instead of env

[Jarod Wilson]

On Tue, Jan 26, 2010 at 9:34 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote:
> On Wed, Jan 27, 2010 at 6:20 AM, Don Zickus <dzickus@redhat.com> wrote:
>> Doh. Typo in the To: field
>>
>> ----- Forwarded message from Don Zickus <dzickus@redhat.com> -----
>>
>> Date: Fri, 22 Jan 2010 16:32:10 -0500
>> From: Don Zickus <dzickus@redhat.com>
>> To: lkml@vger.kernel.org
>> Cc: akpm@linux-foundation.org, tglx@linutronix.de, tony.luck@intel.com,
>>        kmcmartin@redhat.com, Don Zickus <dzickus@redhat.com>
>> Subject: [scripts] python: change scripts to use system python instead of env
>> Message-Id: <1264195930-15815-1-git-send-email-dzickus@redhat.com>
>>
>> Just a small change to a couple of scripts to go from
>>
>>  #!/usr/bin/env python
>>
>> to
>>
>>  #!/usr/bin/python
>>
>> This shouldn't effect anyone, unless they don't install python there.
>>
>> In preparation for python3, Fedora is doing a big push to change the scripts
>> to use the system python.  This allows developers to put the python3 in
>> their path without fear of breaking existing scripts.
>>
>> Now I am pretty sure anyone using python3 for testing purposes will probably
>> not run any of the scripts I changed, but Fedora has this automated tool
>> that checks for this stuff so I thought I would try to push it upstream.
>
>
> Hmm, so python3 will be installed in /usr/local/bin?

No, it will be /usr/bin/python3, but its possible a user would
configure their environment to have their default python interpreter
be python3, in which case env python would be using /usr/bin/python3
rather than /usr/bin/python, which can lead to things mysteriously
running differently or not running at all.

Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@wilsonet.com

Re: [scripts] python: change scripts to use system python instead of env

[Michal Marek]

Jarod Wilson napsal(a):
> On Tue, Jan 26, 2010 at 9:34 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote:
>> On Wed, Jan 27, 2010 at 6:20 AM, Don Zickus <dzickus@redhat.com> wrote:
>>> Just a small change to a couple of scripts to go from
>>>
>>>  #!/usr/bin/env python
>>>
>>> to
>>>
>>>  #!/usr/bin/python
...
>>
>> Hmm, so python3 will be installed in /usr/local/bin?
> 
> No, it will be /usr/bin/python3, but its possible a user would
> configure their environment to have their default python interpreter
> be python3, in which case env python would be using /usr/bin/python3
> rather than /usr/bin/python, which can lead to things mysteriously
> running differently or not running at all.
> 
> Acked-by: Jarod Wilson <jarod@redhat.com>

OK, and we have other python scripts that already use #!/usr/bin/python,
so this patch makes sense regardless of python3. I added it to the
kbuild tree.

Michal