From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thiago Farina <tfransosi@gmail.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH] tools/perf/perf.c: Clean up trivial style issues.
Date: Wed, 27 Jan 2010 10:44:55 -0200 [thread overview]
Message-ID: <20100127124454.GB12567@ghostprotocols.net> (raw)
In-Reply-To: <20100127115942.GD28168@elte.hu>
Em Wed, Jan 27, 2010 at 12:59:42PM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>
> > Em Sun, Jan 24, 2010 at 06:21:46PM -0500, Thiago Farina escreveu:
> > > Checked with:
> > > ./../scripts/checkpatch.pl --terse --file perf.c
> > >
> > > perf.c:51: ERROR: open brace '{' following function declarations go on the next line
> > > perf.c:73: ERROR: "foo*** bar" should be "foo ***bar"
> > > perf.c:112: ERROR: space prohibited before that close parenthesis ')'
> > > perf.c:127: ERROR: space prohibited before that close parenthesis ')'
> > > perf.c:171: ERROR: "foo** bar" should be "foo **bar"
> > > perf.c:213: ERROR: "(foo*)" should be "(foo *)"
> > > perf.c:216: ERROR: "(foo*)" should be "(foo *)"
> > > perf.c:217: ERROR: space required before that '*' (ctx:OxV)
> > > perf.c:452: ERROR: do not initialise statics to 0 or NULL
> > > perf.c:453: ERROR: do not initialise statics to 0 or NULL
> >
> > I'm ok with this, all comes from git lack of checkpatchin', from where
> > this code was stolen^Wlifted, I guess :-)
> >
> > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Mind picking it up into your tree and sending it to me with your next series
> of patches?
Sure thing.
- Arnaldo
prev parent reply other threads:[~2010-01-27 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-24 23:21 [PATCH] tools/perf/perf.c: Clean up trivial style issues Thiago Farina
2010-01-25 0:16 ` Arnaldo Carvalho de Melo
2010-01-27 11:59 ` Ingo Molnar
2010-01-27 12:44 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127124454.GB12567@ghostprotocols.net \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox