public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3][resend] set block size to PAGE_SIZE and some cleanups
Date: Wed, 27 Jan 2010 20:23:38 -0800	[thread overview]
Message-ID: <20100128042338.GA7004@kroah.com> (raw)
In-Reply-To: <4B610BA6.2020009@vflare.org>

On Thu, Jan 28, 2010 at 09:29:34AM +0530, Nitin Gupta wrote:
> [replace stat_*() with rzs_stat*()]
> ---
> 
> ramzswap block size needs to be set to PAGE_SIZE
> to avoid receiving any unaligned block I/O (happens
> during swapon time). These unaligned access produce
> unncessary I/O errors, scaring users.
> 
> Also included some minor cleanups.

Such as?

Could you break this into 2 patches, one the block size stuff, and the
other the cleanups?  Remember, 1 patch does 1 thing.

thanks,

greg k-h

  reply	other threads:[~2010-01-28  4:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 14:24 [PATCH 0/3][linux-next] ramzswap: bug fixes and some cleanups Nitin Gupta
2010-01-27 14:24 ` [PATCH 1/3] use lock for 64-bit stats Nitin Gupta
2010-01-27 15:10   ` Pekka Enberg
2010-01-27 15:51     ` Nitin Gupta
2010-01-28  2:19   ` [PATCH 1/3][resend] " Nitin Gupta
2010-01-27 14:24 ` [PATCH 2/3] flush block device before reset Nitin Gupta
2010-01-27 14:24 ` [PATCH 3/3] set block size to PAGE_SIZE and some cleanups Nitin Gupta
2010-01-28  3:59   ` [PATCH 3/3][resend] " Nitin Gupta
2010-01-28  4:23     ` Greg KH [this message]
2010-01-28  5:37       ` Nitin Gupta
2010-01-28  5:54         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100128042338.GA7004@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox