public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: mingo@elte.hu, peterz@infradead.org, aris@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] [RFC][x86] move notify_die from nmi.c to traps.c
Date: Thu, 28 Jan 2010 18:10:25 +0300	[thread overview]
Message-ID: <20100128151025.GA5338@lenovo> (raw)
In-Reply-To: <1264622622-5778-2-git-send-email-dzickus@redhat.com>

On Wed, Jan 27, 2010 at 03:03:40PM -0500, Don Zickus wrote:
...
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index 3339917..3b98dd3 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -400,6 +400,11 @@ static notrace __kprobes void default_do_nmi(struct pt_regs *regs)
>  		if (notify_die(DIE_NMI_IPI, "nmi_ipi", regs, reason, 2, SIGINT)
>  								== NOTIFY_STOP)
>  			return;
> +
> +	        if (notify_die(DIE_NMI, "nmi", regs, reason, 2, SIGINT)
> +	        			                == NOTIFY_STOP)
> +	                return;
> +
>  #ifdef CONFIG_X86_LOCAL_APIC
>  		/*
>  		 * Ok, so this is none of the documented NMI sources,
> --

Hi Don, I suppose this notify_die should be in CONFIG_X86_LOCAL_APIC
section?
 
	-- Cyrill

  reply	other threads:[~2010-01-28 15:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 20:03 [PATCH 0/3] [RFC] new nmi_watchdog using perf events Don Zickus
2010-01-27 20:03 ` [PATCH 1/3] [RFC][x86] move notify_die from nmi.c to traps.c Don Zickus
2010-01-28 15:10   ` Cyrill Gorcunov [this message]
2010-01-28 15:46     ` Don Zickus
2010-02-02 17:59       ` Cyrill Gorcunov
2010-02-02 18:27         ` Don Zickus
2010-02-02 18:44           ` Cyrill Gorcunov
2010-01-27 20:03 ` [PATCH 2/3] [RFC] nmi_watchdog: new implementation using perf events Don Zickus
2010-01-27 20:03 ` [PATCH 3/3] [RFC] nmi_watchdog: config option to enable new nmi_watchdog Don Zickus
2010-01-28 14:54   ` Peter Zijlstra
2010-01-28 15:44     ` Don Zickus
2010-01-29  8:12       ` Ingo Molnar
2010-02-01 18:52         ` Don Zickus
2010-02-02  7:29           ` Ingo Molnar
2010-02-02 16:42             ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100128151025.GA5338@lenovo \
    --to=gorcunov@gmail.com \
    --cc=aris@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox