From: Paul Mundt <lethal@linux-sh.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux@arm.linux.org.uk, eric.y.miao@gmail.com, tony@atomide.com,
linux-kernel@vger.kernel.org, khilman@deeprootsystems.com,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/06] sh: Let INTC set IRQF_VALID on ARM platforms
Date: Fri, 29 Jan 2010 11:50:41 +0900 [thread overview]
Message-ID: <20100129025041.GB7396@linux-sh.org> (raw)
In-Reply-To: <20100128124121.8982.71803.sendpatchset@rxone.opensource.se>
On Thu, Jan 28, 2010 at 09:41:21PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Reuse the SuperH INTC code on ARM by using set_irq_flags()
> to set IRQF_VALID on ARM platforms. Reworking the shared ARM
> interrupt code and removing IRQF_VALID is another option.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> drivers/sh/intc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- 0001/drivers/sh/intc.c
> +++ work/drivers/sh/intc.c 2010-01-21 19:53:15.000000000 +0900
> @@ -658,6 +658,11 @@ static void __init intc_register_irq(str
>
> if (desc->ack_regs)
> ack_handle[irq] = intc_ack_data(desc, d, enum_id);
> +
> + /* Set IRQF_VALID to enable IRQ on ARM systems */
> +#ifdef CONFIG_ARCH_SHMOBILE
> + set_irq_flags(irq, IRQF_VALID);
> +#endif
> }
>
This should be CONFIG_ARM rather than ARCH_SHMOBILE, as it's hardly
SH-Mobile specific.
next prev parent reply other threads:[~2010-01-29 2:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 12:40 [PATCH 00/06] ARM: Initial SuperH Mobile ARM support Magnus Damm
2010-01-28 12:40 ` [PATCH 01/06] ARM: SuperH Mobile ARM, sh7367 and G3EVM support Magnus Damm
2010-01-28 22:08 ` Russell King - ARM Linux
2010-01-29 11:26 ` Magnus Damm
2010-02-01 14:10 ` Pavel Machek
2010-02-01 14:26 ` Paul Mundt
2010-02-01 16:19 ` Linus Walleij
2010-02-02 0:12 ` Paul Mundt
2010-01-28 12:40 ` [PATCH 02/06] ARM: Add sh7377 and G4EVM support Magnus Damm
2010-01-28 12:41 ` [PATCH 03/06] ARM: Add sh7372 and AP4EVB support Magnus Damm
2010-01-28 22:19 ` Russell King - ARM Linux
2010-01-28 12:41 ` [PATCH 04/06] sh: Build drivers/sh for SuperH Mobile ARM Magnus Damm
2010-01-28 12:41 ` [PATCH 05/06] sh: Let INTC set IRQF_VALID on ARM platforms Magnus Damm
2010-01-29 2:50 ` Paul Mundt [this message]
2010-01-28 12:41 ` [PATCH 06/06] sh-sci: Preliminary SuperH Mobile ARM support Magnus Damm
2010-01-29 2:52 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129025041.GB7396@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=ben-linux@fluff.org \
--cc=eric.y.miao@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox