public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: add block topology support
Date: Sat, 30 Jan 2010 15:29:49 +1030	[thread overview]
Message-ID: <201001301529.49848.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100129190158.GA25122@lst.de>

On Sat, 30 Jan 2010 05:31:58 am Christoph Hellwig wrote:
> Allow reading various alignment values from the config page.  This
> allows the guest to much better align I/O requests depending on the
> storage topology.
> 
> Note that the formats for the config values appear a bit messed up,
> but we follow the formats used by ATA and SCSI so they are expected in
> the storage world.

I bow to your expertise on that.  My only query is the __u16 for min_io_size; is that likely to restrict us?

Also, patch seems to be based on a prior one?

>  	/* Use topology information if available */
> -	err = virtio_config_val(vdev, VIRTIO_BLK_F_BLK_TOPOLOGY,
> +	err = virtio_config_val(vdev, VIRTIO_BLK_F_TOPOLOGY,
> +			offsetof(struct virtio_blk_config, physical_block_exp),
> +			&physical_block_exp);

Thanks,
Rusty.

  reply	other threads:[~2010-01-30  4:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 19:01 [PATCH] virtio_blk: add block topology support Christoph Hellwig
2010-01-30  4:59 ` Rusty Russell [this message]
2010-01-30 20:19   ` Christoph Hellwig
2010-02-01  1:10     ` Rusty Russell
2011-07-14 23:36       ` Alexey Zaytsev
2011-07-21  7:53         ` Rusty Russell
2011-07-29 19:09           ` Alexey Zaytsev
2011-07-30  4:52             ` Rusty Russell
2011-07-31 18:19               ` Christoph Hellwig
2011-08-01  5:22                 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001301529.49848.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=borntraeger@de.ibm.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox