Samsung N220 backlight support

Samsung N220 backlight support

[Christian Hesse]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hello Greg,

this adds support for Samsung N220 to your samsung-backlight. Tested on my 
device, works for me.

Regards,
Chris

Signed-off-by: Christian Hesse <mail@earthworm.de>


[-- Attachment #2: samsung-backlight-n220.diff --]
[-- Type: text/x-patch, Size: 1426 bytes --]

--- samsung-backlight.c~	2010-01-28 19:10:40.000000000 +0100
+++ samsung-backlight.c	2010-01-28 19:18:50.000000000 +0100
@@ -105,6 +105,15 @@ static struct dmi_system_id __initdata s
 		.callback = dmi_check_cb,
 	},
 	{
+		.ident = "N220",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N220"),
+			DMI_MATCH(DMI_BOARD_NAME, "N220"),
+		},
+		.callback = dmi_check_cb,
+	},
+	{
 		.ident = "NC10",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
@@ -138,8 +147,11 @@ static int __init samsung_init(void)
 	pci_device = pci_get_device(PCI_VENDOR_ID_INTEL, 0x27ae, NULL);
 	if (!pci_device) {
 		pci_device = pci_get_device(PCI_VENDOR_ID_INTEL, 0x2a02, NULL);
-		if (!pci_device)
+		if (!pci_device) {
+			pci_device = pci_get_device(PCI_VENDOR_ID_INTEL, 0xa011, NULL);
+			if (!pci_device)
 			return -ENODEV;
+		}
 	}
 
 	/* create a backlight device to talk to this one */
@@ -175,5 +187,6 @@ MODULE_DESCRIPTION("Samsung Backlight dr
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("dmi:*:svnSAMSUNGELECTRONICSCO.,LTD.:pnN120:*:rnN120:*");
 MODULE_ALIAS("dmi:*:svnSAMSUNGELECTRONICSCO.,LTD.:pnN130:*:rnN130:*");
+MODULE_ALIAS("dmi:*:svnSAMSUNGELECTRONICSCO.,LTD.:pnN220:*:rnN220:*");
 MODULE_ALIAS("dmi:*:svnSAMSUNGELECTRONICSCO.,LTD.:pnNC10:*:rnNC10:*");
 MODULE_ALIAS("dmi:*:svnSAMSUNGELECTRONICSCO.,LTD.:pnSQ45S70S:*:rnSQ45S70S:*");

Re: Samsung N220 backlight support

[Greg KH]

On Sat, Jan 30, 2010 at 05:06:18PM +0100, Christian Hesse wrote:
> Hello Greg,
> 
> this adds support for Samsung N220 to your samsung-backlight. Tested on my 
> device, works for me.

Hm, the driver that ended up in the kernel is very different from this
version.  Can you work with that version and add the needed changes
there and generate a patch?

thanks,

greg k-h

Re: Samsung N220 backlight support

[Christian Hesse]

[-- Attachment #1: Type: Text/Plain, Size: 1034 bytes --]

On Saturday 30 January 2010 17:28:57 you wrote:
> On Sat, Jan 30, 2010 at 05:06:18PM +0100, Christian Hesse wrote:
> > Hello Greg,
> >
> > this adds support for Samsung N220 to your samsung-backlight. Tested on
> > my device, works for me.
> 
> Hm, the driver that ended up in the kernel is very different from this
> version.  Can you work with that version and add the needed changes
> there and generate a patch?

Oh, did not notice it was included in mainline already.
I applied the attached patch. Insmod now gives:

insmod: error inserting 'samsung-laptop.ko': -1 Invalid parameters

and the logs contain the following:

kernel: samsung_laptop: found laptop model 'N220'
kernel: This computer does not support SABI

What is this SABI and SECLINUX thing about? Do you have a link to any more 
information? Is it possible that the N220 does not have this?
The N220 uses a Pine Train platform (featuring N450 with 64bit support), so I 
installed x86_64 to the device.

I would be glad to test whatever you give me.

Regards,
Chris

[-- Attachment #2: samsung-laptop-n220.diff --]
[-- Type: text/x-patch, Size: 593 bytes --]

--- linux-2.6.33-rc6/drivers/staging/samsung-laptop/samsung-laptop.c	2010-01-30 17:40:18.000000000 +0100
+++ linux-2.6.33-rc6/drivers/staging/samsung-laptop/samsung-laptop.c	2010-01-30 18:27:06.000000000 +0100
@@ -385,6 +385,15 @@ static struct dmi_system_id __initdata s
 		},
 		.callback = dmi_check_cb,
 	},
+	{
+		.ident = "N220",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N220"),
+			DMI_MATCH(DMI_BOARD_NAME, "N220"),
+		},
+		.callback = dmi_check_cb,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(dmi, samsung_dmi_table);

Re: Samsung N220 backlight support

[Greg KH]

On Sat, Jan 30, 2010 at 07:37:34PM +0100, Christian Hesse wrote:
> Oh, did not notice it was included in mainline already.
> I applied the attached patch. Insmod now gives:
> 
> insmod: error inserting 'samsung-laptop.ko': -1 Invalid parameters
> 
> and the logs contain the following:
> 
> kernel: samsung_laptop: found laptop model 'N220'
> kernel: This computer does not support SABI
> 
> What is this SABI and SECLINUX thing about?

It is the BIOS interface that the kernel talks to.

> Do you have a link to any more information?

No, I don't know of any public information on this interface, sorry.

> Is it possible that the N220 does not have this?

Yes, it does not.

> The N220 uses a Pine Train platform (featuring N450 with 64bit support), so I 
> installed x86_64 to the device.
> 
> I would be glad to test whatever you give me.

I'm sorry, but I am not allowed to make any changes to the driver to
support other laptops at this time, but I can accept patches written by
others.

Yeah, it sucks, sorry.

greg k-h