From: Ingo Molnar <mingo@elte.hu>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: fix write_event()
Date: Sun, 31 Jan 2010 09:32:34 +0100 [thread overview]
Message-ID: <20100131083234.GA12637@elte.hu> (raw)
In-Reply-To: <4B570657.5090105@cn.fujitsu.com>
* Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:
> We parse the event while it's read from mmap buffer in
> write_event(), but sometimes the event will straddles the
> mmap boundary, we should handle this case
>
> And if we record events(such as perf kmem/sched) for long
> times, Ctrl + C can't interrupt it just for this reason
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
> tools/perf/builtin-record.c | 62 +++++++++++++++++++++++++++++++++---------
Note, i've reverted the original instead, via:
a8e6f73: Revert "perf record: Intercept all events"
As Peter said it, it is fundamentally wrong for perf record to touch the data
stream in the common case. Arnaldo, cannot we use some other method for perf
archive's needs? Worst-case we can do an optional parsing of the data stream
although we should first try hard to find a generic method ...
Ingo
next prev parent reply other threads:[~2010-01-31 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 13:34 [PATCH] perf tools: fix write_event() Xiao Guangrong
2010-01-20 13:41 ` Peter Zijlstra
2010-01-20 13:44 ` Peter Zijlstra
2010-01-20 14:09 ` Arnaldo Carvalho de Melo
2010-01-20 14:14 ` Peter Zijlstra
2010-01-20 14:26 ` Arnaldo Carvalho de Melo
2010-01-20 14:37 ` Peter Zijlstra
2010-01-20 15:43 ` Arnaldo Carvalho de Melo
2010-01-20 14:43 ` Peter Zijlstra
2010-01-20 15:30 ` Arnaldo Carvalho de Melo
2010-01-20 13:41 ` Frederic Weisbecker
2010-01-31 8:32 ` Ingo Molnar [this message]
2010-02-01 8:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100131083234.GA12637@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox