From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: add block topology support
Date: Mon, 1 Feb 2010 11:40:05 +1030 [thread overview]
Message-ID: <201002011140.05761.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100130201910.GA19811@lst.de>
On Sun, 31 Jan 2010 06:49:10 am Christoph Hellwig wrote:
> On Sat, Jan 30, 2010 at 03:29:49PM +1030, Rusty Russell wrote:
> > I bow to your expertise on that. My only query is the __u16 for min_io_size; is that likely to restrict us?
>
> Looks like you caught me there - I wrote the above odd format about the
> physical_block exponent, but scsi actually does the min_io and opt_io
> size in logical blocks, too. With that in account the u16 as in scsi
> is perfectly fine.
Thanks, applied.
Rusty.
next prev parent reply other threads:[~2010-02-01 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 19:01 [PATCH] virtio_blk: add block topology support Christoph Hellwig
2010-01-30 4:59 ` Rusty Russell
2010-01-30 20:19 ` Christoph Hellwig
2010-02-01 1:10 ` Rusty Russell [this message]
2011-07-14 23:36 ` Alexey Zaytsev
2011-07-21 7:53 ` Rusty Russell
2011-07-29 19:09 ` Alexey Zaytsev
2011-07-30 4:52 ` Rusty Russell
2011-07-31 18:19 ` Christoph Hellwig
2011-08-01 5:22 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002011140.05761.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=borntraeger@de.ibm.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox