From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, fengguang.wu@intel.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] Generic page_is_ram: use __weak
Date: Mon, 1 Feb 2010 17:55:06 -0800 [thread overview]
Message-ID: <20100201175506.5a0b01c1.akpm@linux-foundation.org> (raw)
In-Reply-To: <4B6781D3.6090904@zytor.com>
On Mon, 01 Feb 2010 17:37:23 -0800 "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 02/01/2010 05:24 PM, Andrew Morton wrote:
> >>
> >> diff --git a/kernel/resource.c b/kernel/resource.c
> >> index b4d637a..e68cd74 100644
> >> --- a/kernel/resource.c
> >> +++ b/kernel/resource.c
> >> @@ -305,7 +305,7 @@ static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
> >> * This generic page_is_ram() returns true if specified address is
> >> * registered as "System RAM" in iomem_resource list.
> >> */
> >> -int __attribute__((weak)) page_is_ram(unsigned long pfn)
> >> +int __weak page_is_ram(unsigned long pfn)
> >> {
> >> return walk_system_ram_range(pfn, 1, NULL, __is_ram) == 1;
> >> }
> >
> > hm, it's strange to do this as two separate commits?
> >
>
> You had it as a separate fix patch, and I generally don't want to fold
> patches which have different authorship, especially if the original code
> doesn't actually break anything.
Nobody's complained so far:
y:/usr/src/git26> git log | grep '\[.*@.*:' | wc -l
2434
It's a tradeoff between being nice to authors versus tree-cleanliness
and bisectability.
next prev parent reply other threads:[~2010-02-02 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-e52730071567ec5b6f57e21d6693b112e01e1d0e@git.kernel.org>
2010-02-02 1:24 ` [tip:x86/mm] Generic page_is_ram: use __weak Andrew Morton
2010-02-02 1:37 ` H. Peter Anvin
2010-02-02 1:55 ` Andrew Morton [this message]
2010-02-02 1:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201175506.5a0b01c1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox