linux-next: sound tree build failure

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) failed like this:

sound/soc/codecs/wm8994.c:30:35: error: linux/mfd/wm8994/core.h: No such file or directory
sound/soc/codecs/wm8994.c:31:40: error: linux/mfd/wm8994/registers.h: No such file or directory
sound/soc/codecs/wm8994.c:32:36: error: linux/mfd/wm8994/pdata.h: No such file or directory
sound/soc/codecs/wm8994.c:33:35: error: linux/mfd/wm8994/gpio.h: No such file or directory

And went down hill form there :-(

Caused by commit 9e6e96a197a03752d39a63e4f83e0b707ccedad7 ("ASoC: Add
WM8994 CODEC driver").  I presume that this commit depends on commits
currently only in the mfd tree ...

I have used the sound tree from next-20100201 for today.

To fix this, the relevant commits from the mfd tree could be put into a
"never to be rebased" branch (or separate git tree) and then this branch
merged into both the sound and mfd trees.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Tue, 2 Feb 2010 12:47:11 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> sound/soc/codecs/wm8994.c:30:35: error: linux/mfd/wm8994/core.h: No such file or directory
> sound/soc/codecs/wm8994.c:31:40: error: linux/mfd/wm8994/registers.h: No such file or directory
> sound/soc/codecs/wm8994.c:32:36: error: linux/mfd/wm8994/pdata.h: No such file or directory
> sound/soc/codecs/wm8994.c:33:35: error: linux/mfd/wm8994/gpio.h: No such file or directory
> 
> And went down hill form there :-(

Ah, sorry, this driver didn't hit in my quick test in the last
evening before pushing.

> Caused by commit 9e6e96a197a03752d39a63e4f83e0b707ccedad7 ("ASoC: Add
> WM8994 CODEC driver").  I presume that this commit depends on commits
> currently only in the mfd tree ...

Yep, looks so.
 
> I have used the sound tree from next-20100201 for today.
> 
> To fix this, the relevant commits from the mfd tree could be put into a
> "never to be rebased" branch (or separate git tree) and then this branch
> merged into both the sound and mfd trees.

Well, I don't think the codec register definitions don't have to be
dependent on mfd tree at all.  All other codec drivers have own
definitions.

Mark, can it be self-contained?


thanks,

Takashi

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 08:27:19AM +0100, Takashi Iwai wrote:

> Well, I don't think the codec register definitions don't have to be
> dependent on mfd tree at all.  All other codec drivers have own
> definitions.

> Mark, can it be self-contained?

No, it needs to look at things like the multi-function pin configuration
in order to configure itself correctly.

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Tue, 2 Feb 2010 10:31:12 +0000,
Mark Brown wrote:
> 
> On Tue, Feb 02, 2010 at 08:27:19AM +0100, Takashi Iwai wrote:
> 
> > Well, I don't think the codec register definitions don't have to be
> > dependent on mfd tree at all.  All other codec drivers have own
> > definitions.
> 
> > Mark, can it be self-contained?
> 
> No, it needs to look at things like the multi-function pin configuration
> in order to configure itself correctly.

Hm, then shouldn't it depend on mfd?



Takashi

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 11:40:03AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > No, it needs to look at things like the multi-function pin configuration
> > in order to configure itself correctly.

> Hm, then shouldn't it depend on mfd?

Yes, I've got a patch for that which I'll send shortly (though that
shouldn't affect the -next build it will affect the sound build).

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 12:47:11PM +1100, Stephen Rothwell wrote:

> sound/soc/codecs/wm8994.c:30:35: error: linux/mfd/wm8994/core.h: No such file or directory
> sound/soc/codecs/wm8994.c:31:40: error: linux/mfd/wm8994/registers.h: No such file or directory
> sound/soc/codecs/wm8994.c:32:36: error: linux/mfd/wm8994/pdata.h: No such file or directory
> sound/soc/codecs/wm8994.c:33:35: error: linux/mfd/wm8994/gpio.h: No such file or directory

> And went down hill form there :-(

This looks really odd - all those headers are present in the linux-next
tree (and have been for a few days) as far as I can tell, and I can't
see any way they could not be found without serious breakage elsewhere.
Could you please re-run your build with V=1 to show the kernel command
line used to build the driver?  I can't reproduce this here and like I
say I can't see how this could happen given that those files are there
in -next and it's hard to see how this could happen.

> Caused by commit 9e6e96a197a03752d39a63e4f83e0b707ccedad7 ("ASoC: Add
> WM8994 CODEC driver").  I presume that this commit depends on commits
> currently only in the mfd tree ...

Not exactly, there's a Kconfig dependency which should keep track of
things but the wrong one got merged over when things got split out to go
into the several trees.  Though for allmodconfig that will not be
relevant since the dependency will be satisfied anyway and the headers
don't need Kconfig to pull them in.

Like I say, everything required is in the MFD tree in -next anyway.

> I have used the sound tree from next-20100201 for today.

> To fix this, the relevant commits from the mfd tree could be put into a
> "never to be rebased" branch (or separate git tree) and then this branch
> merged into both the sound and mfd trees.

This is not needed, Kconfig will handle it.

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]

Hi Mark,

On Tue, 2 Feb 2010 10:26:10 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> This looks really odd - all those headers are present in the linux-next
> tree (and have been for a few days) as far as I can tell, and I can't
> see any way they could not be found without serious breakage elsewhere.
> Could you please re-run your build with V=1 to show the kernel command
> line used to build the driver?  I can't reproduce this here and like I
> say I can't see how this could happen given that those files are there
> in -next and it's hard to see how this could happen.

The sound tree is merged before the mfd tree, and the commit that adds
those is only in the mfd tree.  So the sound tree, on its own, is
broken.  This driver will only build if you merge the mfd tree as well.

> > Caused by commit 9e6e96a197a03752d39a63e4f83e0b707ccedad7 ("ASoC: Add
> > WM8994 CODEC driver").  I presume that this commit depends on commits
> > currently only in the mfd tree ...
> 
> Not exactly, there's a Kconfig dependency which should keep track of
> things but the wrong one got merged over when things got split out to go
> into the several trees.  Though for allmodconfig that will not be
> relevant since the dependency will be satisfied anyway and the headers
> don't need Kconfig to pull them in.
> 
> Like I say, everything required is in the MFD tree in -next anyway.

yes, but I do builds between merging trees ...

> > I have used the sound tree from next-20100201 for today.
> 
> > To fix this, the relevant commits from the mfd tree could be put into a
> > "never to be rebased" branch (or separate git tree) and then this branch
> > merged into both the sound and mfd trees.
> 
> This is not needed, Kconfig will handle it.

Kconfig has nothing to do with it, sorry.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 09:37:32PM +1100, Stephen Rothwell wrote:

> The sound tree is merged before the mfd tree, and the commit that adds
> those is only in the mfd tree.  So the sound tree, on its own, is
> broken.  This driver will only build if you merge the mfd tree as well.

Ah, you're doing builds after each individual merge.  It might help to
change the form you're using when reporting problems with partially
constructed -next - at the minute you say "Today's linux-next build
(x86_64 allmodconfig) failed like this:" which makes it look like you're
testing the result of the full -next merge.

> > > To fix this, the relevant commits from the mfd tree could be put into a
> > > "never to be rebased" branch (or separate git tree) and then this branch
> > > merged into both the sound and mfd trees.

> > This is not needed, Kconfig will handle it.

> Kconfig has nothing to do with it, sorry.

No, it does really fix the problem.  As I said the driver should build
depend on a Kconfig symbol which is introduced in the MFD tree.  This
means that the driver will not be built at all until MFD has been merged
since the dependencies required to select the driver will not be
satisfied unless the commits it depends on are present in the tree.

I'll push a patch for this shortly.

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi Mark,

On Tue, 2 Feb 2010 10:58:00 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Tue, Feb 02, 2010 at 09:37:32PM +1100, Stephen Rothwell wrote:
> 
> > The sound tree is merged before the mfd tree, and the commit that adds
> > those is only in the mfd tree.  So the sound tree, on its own, is
> > broken.  This driver will only build if you merge the mfd tree as well.
> 
> Ah, you're doing builds after each individual merge.  It might help to

Always have ...

> change the form you're using when reporting problems with partially
> constructed -next - at the minute you say "Today's linux-next build
> (x86_64 allmodconfig) failed like this:" which makes it look like you're
> testing the result of the full -next merge.

I was hoping that the subject of the email would help with that
impression.

> > Kconfig has nothing to do with it, sorry.
> 
> No, it does really fix the problem.  As I said the driver should build
> depend on a Kconfig symbol which is introduced in the MFD tree.  This
> means that the driver will not be built at all until MFD has been merged
> since the dependencies required to select the driver will not be
> satisfied unless the commits it depends on are present in the tree.

Yeah, OK, I guess you could do that.

> I'll push a patch for this shortly.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 10:17:43PM +1100, Stephen Rothwell wrote:
> On Tue, 2 Feb 2010 10:58:00 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> > change the form you're using when reporting problems with partially
> > constructed -next - at the minute you say "Today's linux-next build
> > (x86_64 allmodconfig) failed like this:" which makes it look like you're
> > testing the result of the full -next merge.

> I was hoping that the subject of the email would help with that
> impression.

The way I've always read that was that you'd found a build failure in
a given bit of the tree while testing -next - you're clearly doing some
work to identify and understand where the failure came from (and simply
looking at the source file leads to the same result normally anyway) so
the fact that you've identified the subsystem doesn't automatically say
that this happened with a partially merged -next.  If you looked less
like a human the subject by itself would be clearer :)

> > > Kconfig has nothing to do with it, sorry.

> > No, it does really fix the problem.  As I said the driver should build
> > depend on a Kconfig symbol which is introduced in the MFD tree.  This
> > means that the driver will not be built at all until MFD has been merged
> > since the dependencies required to select the driver will not be
> > satisfied unless the commits it depends on are present in the tree.

> Yeah, OK, I guess you could do that.

It's needed anyway, the driver will try to link against the MFD core so
even with both bits merged a build that didn't select the core would
fail.

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

Hi Mark,

On Tue, 2 Feb 2010 11:34:24 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> The way I've always read that was that you'd found a build failure in
> a given bit of the tree while testing -next - you're clearly doing some
> work to identify and understand where the failure came from (and simply
> looking at the source file leads to the same result normally anyway) so
> the fact that you've identified the subsystem doesn't automatically say
> that this happened with a partially merged -next.  If you looked less
> like a human the subject by itself would be clearer :)

How about "linux-next: build failure after merging xxx tree"?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Mark Brown]

On Tue, Feb 02, 2010 at 10:55:45PM +1100, Stephen Rothwell wrote:

> How about "linux-next: build failure after merging xxx tree"?

Yes that's a lot clearer, thanks.

Re: linux-next: sound tree build failure

[Liam Girdwood]

Hi Stephen,

On Tue, 2010-02-02 at 22:17 +1100, Stephen Rothwell wrote:
> Hi Mark,
> 
> On Tue, 2 Feb 2010 10:58:00 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> >
> > On Tue, Feb 02, 2010 at 09:37:32PM +1100, Stephen Rothwell wrote:
> > 
> > > The sound tree is merged before the mfd tree, and the commit that adds
> > > those is only in the mfd tree.  So the sound tree, on its own, is
> > > broken.  This driver will only build if you merge the mfd tree as well.
> > 
> > Ah, you're doing builds after each individual merge.  It might help to
> 
> Always have ...
> 

I wonder if it would be possible to re-order the merge sequence so that
similar inter tree dependencies are less likely to cause -next build
failures in the future.  I guess atm lots of driver trees can depend on
MFD (e.g. regulator, sound, rtc, backlight, led, watchdog, etc) so it
may be good to move it up the order.

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Hi Liam,

On Tue, 02 Feb 2010 11:50:30 +0000 Liam Girdwood <lrg@slimlogic.co.uk> wrote:
>
> I wonder if it would be possible to re-order the merge sequence so that
> similar inter tree dependencies are less likely to cause -next build

Anything is possible with software :-)

> failures in the future.  I guess atm lots of driver trees can depend on
> MFD (e.g. regulator, sound, rtc, backlight, led, watchdog, etc) so it
> may be good to move it up the order.

In this case it would just have masked the dependency and we may not have
found it until the sound tree was merged into Linus' tree and builds
started failing.  (I now Mark already knew about this one.)  We actually
have very few build dependencies between trees and in most cases I would
prefer that they were exposed in linux-next than in Linus' tree (with the
ensuing bisection problems).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: sound tree build failure

[Stephen Rothwell]

Hi Takashi,

Today's linux-next build (i386 defconfig) failed like this:

sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'

Caused by commit eb7188cafcb7aa1419b8889494cdbd4e6a01da1c ("ALSA: HDA
VIA: Add VT1718S support").

sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'

Caused by commit f3db423df84570c9950754a5771ad26f0111235f ("ALSA: HDA
VIA: Add VT1716S support").

sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'

Caused by commit 25eaba2f8a6877ba6f58197c4723c2433a316e09 ("ALSA: HDA VIA: Add VT2002P support").

sound/pci/hda/patch_via.c: In function 'patch_vt1812':
sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'

Caused by commit ab6734e7ea32e9f9cbe0f55eeddf4aa629ed1c3d ("ALSA: HDA VIA: Add VT1812 support").

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 12 Oct 2009 15:56:17 +1100
Subject: [PATCH] sound: use semicolons to end statements

Fixes:

sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
sound/pci/hda/patch_via.c: In function 'patch_vt1812':
sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/pci/hda/patch_via.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 30260e2..a294060 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -4942,7 +4942,7 @@ static int patch_vt1718S(struct hda_codec *codec)
 	codec->patch_ops = via_patch_ops;
 
 	codec->patch_ops.init = via_auto_init;
-	codec->patch_ops.unsol_event = via_unsol_event,
+	codec->patch_ops.unsol_event = via_unsol_event;
 
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 	spec->loopback.amplist = vt1718S_loopbacks;
@@ -5432,7 +5432,7 @@ static int patch_vt1716S(struct hda_codec *codec)
 	codec->patch_ops = via_patch_ops;
 
 	codec->patch_ops.init = via_auto_init;
-	codec->patch_ops.unsol_event = via_unsol_event,
+	codec->patch_ops.unsol_event = via_unsol_event;
 
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 	spec->loopback.amplist = vt1716S_loopbacks;
@@ -5785,7 +5785,7 @@ static int patch_vt2002P(struct hda_codec *codec)
 	codec->patch_ops = via_patch_ops;
 
 	codec->patch_ops.init = via_auto_init;
-	codec->patch_ops.unsol_event = via_unsol_event,
+	codec->patch_ops.unsol_event = via_unsol_event;
 
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 	spec->loopback.amplist = vt2002P_loopbacks;
@@ -6139,7 +6139,7 @@ static int patch_vt1812(struct hda_codec *codec)
 	codec->patch_ops = via_patch_ops;
 
 	codec->patch_ops.init = via_auto_init;
-	codec->patch_ops.unsol_event = via_unsol_event,
+	codec->patch_ops.unsol_event = via_unsol_event;
 
 #ifdef CONFIG_SND_HDA_POWER_SAVE
 	spec->loopback.amplist = vt1812_loopbacks;
-- 
1.6.4.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Mon, 12 Oct 2009 16:08:16 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (i386 defconfig) failed like this:
> 
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
> 
> Caused by commit eb7188cafcb7aa1419b8889494cdbd4e6a01da1c ("ALSA: HDA
> VIA: Add VT1718S support").
> 
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
> 
> Caused by commit f3db423df84570c9950754a5771ad26f0111235f ("ALSA: HDA
> VIA: Add VT1716S support").
> 
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
> 
> Caused by commit 25eaba2f8a6877ba6f58197c4723c2433a316e09 ("ALSA: HDA VIA: Add VT2002P support").
> 
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
> 
> Caused by commit ab6734e7ea32e9f9cbe0f55eeddf4aa629ed1c3d ("ALSA: HDA VIA: Add VT1812 support").
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 Oct 2009 15:56:17 +1100
> Subject: [PATCH] sound: use semicolons to end statements
> 
> Fixes:
> 
> sound/pci/hda/patch_via.c: In function 'patch_vt1718S':
> sound/pci/hda/patch_via.c:4951: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1716S':
> sound/pci/hda/patch_via.c:5441: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt2002P':
> sound/pci/hda/patch_via.c:5794: error: expected expression before 'return'
> sound/pci/hda/patch_via.c: In function 'patch_vt1812':
> sound/pci/hda/patch_via.c:6148: error: expected expression before 'return'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

This error happens only when CONFIG_SND_HDA_POWER_SAVE=n, which wasn't
triggered by build tests...

I applied your fix now.  Thanks Stephen!


Takashi


> ---
>  sound/pci/hda/patch_via.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 30260e2..a294060 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -4942,7 +4942,7 @@ static int patch_vt1718S(struct hda_codec *codec)
>  	codec->patch_ops = via_patch_ops;
>  
>  	codec->patch_ops.init = via_auto_init;
> -	codec->patch_ops.unsol_event = via_unsol_event,
> +	codec->patch_ops.unsol_event = via_unsol_event;
>  
>  #ifdef CONFIG_SND_HDA_POWER_SAVE
>  	spec->loopback.amplist = vt1718S_loopbacks;
> @@ -5432,7 +5432,7 @@ static int patch_vt1716S(struct hda_codec *codec)
>  	codec->patch_ops = via_patch_ops;
>  
>  	codec->patch_ops.init = via_auto_init;
> -	codec->patch_ops.unsol_event = via_unsol_event,
> +	codec->patch_ops.unsol_event = via_unsol_event;
>  
>  #ifdef CONFIG_SND_HDA_POWER_SAVE
>  	spec->loopback.amplist = vt1716S_loopbacks;
> @@ -5785,7 +5785,7 @@ static int patch_vt2002P(struct hda_codec *codec)
>  	codec->patch_ops = via_patch_ops;
>  
>  	codec->patch_ops.init = via_auto_init;
> -	codec->patch_ops.unsol_event = via_unsol_event,
> +	codec->patch_ops.unsol_event = via_unsol_event;
>  
>  #ifdef CONFIG_SND_HDA_POWER_SAVE
>  	spec->loopback.amplist = vt2002P_loopbacks;
> @@ -6139,7 +6139,7 @@ static int patch_vt1812(struct hda_codec *codec)
>  	codec->patch_ops = via_patch_ops;
>  
>  	codec->patch_ops.init = via_auto_init;
> -	codec->patch_ops.unsol_event = via_unsol_event,
> +	codec->patch_ops.unsol_event = via_unsol_event;
>  
>  #ifdef CONFIG_SND_HDA_POWER_SAVE
>  	spec->loopback.amplist = vt1812_loopbacks;
> -- 
> 1.6.4.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) failed like this:

make[4]: *** No rule to make target `include/sound/sscape_ioctl.h', needed by `usr/include/sound/.install'.

Caused by commit acd47100914b2896d0699febefd077f85c4dd272 ("ALSA: sscape:
convert to firmware loader framework") which removed
include/sound/sscape_ioctl.h but neglected to update include/sound/Kbuild.

I have used the sound tree from next-20090930 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Fri, 2 Oct 2009 11:15:52 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> make[4]: *** No rule to make target `include/sound/sscape_ioctl.h', needed by `usr/include/sound/.install'.
> 
> Caused by commit acd47100914b2896d0699febefd077f85c4dd272 ("ALSA: sscape:
> convert to firmware loader framework") which removed
> include/sound/sscape_ioctl.h but neglected to update include/sound/Kbuild.

Oops, totally forgot about this.  (And my build test didn't reach here.)
Fixed now.


thanks,

Takashi

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3957 bytes --]

Hi Takashi,

Today's linux-next build (x86_64_allmodconfig) failed like this:

sound/soc/codecs/wm8711.c:523: warning: 'struct spi_device' declared inside parameter list
sound/soc/codecs/wm8711.c:523: warning: its scope is only this definition or declaration, which is probably not what you want
sound/soc/codecs/wm8711.c: In function 'wm8711_spi_probe':
sound/soc/codecs/wm8711.c:534: error: dereferencing pointer to incomplete type
sound/soc/codecs/wm8711.c:536: error: dereferencing pointer to incomplete type
sound/soc/codecs/wm8711.c: At top level:
sound/soc/codecs/wm8711.c:541: warning: 'struct spi_device' declared inside parameter list
sound/soc/codecs/wm8711.c: In function 'wm8711_spi_remove':
sound/soc/codecs/wm8711.c:543: error: dereferencing pointer to incomplete type
sound/soc/codecs/wm8711.c: At top level:
sound/soc/codecs/wm8711.c:551: warning: 'struct spi_device' declared inside parameter list
sound/soc/codecs/wm8711.c: In function 'wm8711_spi_suspend':
sound/soc/codecs/wm8711.c:553: error: dereferencing pointer to incomplete type
sound/soc/codecs/wm8711.c: At top level:
sound/soc/codecs/wm8711.c:556: warning: 'struct spi_device' declared inside parameter list
sound/soc/codecs/wm8711.c: In function 'wm8711_spi_resume':
sound/soc/codecs/wm8711.c:558: error: dereferencing pointer to incomplete type
sound/soc/codecs/wm8711.c: At top level:
sound/soc/codecs/wm8711.c:565: error: variable 'wm8711_spi_driver' has initializer but incomplete type
sound/soc/codecs/wm8711.c:566: error: unknown field 'driver' specified in initializer
sound/soc/codecs/wm8711.c:566: error: extra brace group at end of initializer
sound/soc/codecs/wm8711.c:566: error: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c:568: error: 'spi_bus_type' undeclared here (not in a function)
sound/soc/codecs/wm8711.c:570: warning: excess elements in struct initializer
sound/soc/codecs/wm8711.c:570: warning: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c:571: error: unknown field 'probe' specified in initializer
sound/soc/codecs/wm8711.c:571: warning: excess elements in struct initializer
sound/soc/codecs/wm8711.c:571: warning: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c:572: error: unknown field 'suspend' specified in initializer
sound/soc/codecs/wm8711.c:572: warning: excess elements in struct initializer
sound/soc/codecs/wm8711.c:572: warning: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c:573: error: unknown field 'resume' specified in initializer
sound/soc/codecs/wm8711.c:573: warning: excess elements in struct initializer
sound/soc/codecs/wm8711.c:573: warning: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c:574: error: unknown field 'remove' specified in initializer
sound/soc/codecs/wm8711.c:574: warning: excess elements in struct initializer
sound/soc/codecs/wm8711.c:574: warning: (near initialization for 'wm8711_spi_driver')
sound/soc/codecs/wm8711.c: In function 'wm8711_modinit':
sound/soc/codecs/wm8711.c:635: error: implicit declaration of function 'spi_register_driver'
sound/soc/codecs/wm8711.c:635: error: 'wm8731_spi_driver' undeclared (first use in this function)
sound/soc/codecs/wm8711.c:635: error: (Each undeclared identifier is reported only once
sound/soc/codecs/wm8711.c:635: error: for each function it appears in.)
sound/soc/codecs/wm8711.c: In function 'wm8711_exit':
sound/soc/codecs/wm8711.c:651: error: implicit declaration of function 'spi_unregister_driver'
sound/soc/codecs/wm8711.c:651: error: 'wm8731_spi_driver' undeclared (first use in this function)

Caused by commit 08aff8cd7a8568588d460c4bf8875a492d430314 ("ASoC: Add SPI
support to WM8711").

I have used the version of the sound tree from next-20090930 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Thu, 1 Oct 2009 11:19:35 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (x86_64_allmodconfig) failed like this:
> 
> sound/soc/codecs/wm8711.c:523: warning: 'struct spi_device' declared inside parameter list
> sound/soc/codecs/wm8711.c:523: warning: its scope is only this definition or declaration, which is probably not what you want
> sound/soc/codecs/wm8711.c: In function 'wm8711_spi_probe':
> sound/soc/codecs/wm8711.c:534: error: dereferencing pointer to incomplete type
> sound/soc/codecs/wm8711.c:536: error: dereferencing pointer to incomplete type
> sound/soc/codecs/wm8711.c: At top level:
> sound/soc/codecs/wm8711.c:541: warning: 'struct spi_device' declared inside parameter list
> sound/soc/codecs/wm8711.c: In function 'wm8711_spi_remove':
> sound/soc/codecs/wm8711.c:543: error: dereferencing pointer to incomplete type
> sound/soc/codecs/wm8711.c: At top level:
> sound/soc/codecs/wm8711.c:551: warning: 'struct spi_device' declared inside parameter list
> sound/soc/codecs/wm8711.c: In function 'wm8711_spi_suspend':
> sound/soc/codecs/wm8711.c:553: error: dereferencing pointer to incomplete type
> sound/soc/codecs/wm8711.c: At top level:
> sound/soc/codecs/wm8711.c:556: warning: 'struct spi_device' declared inside parameter list
> sound/soc/codecs/wm8711.c: In function 'wm8711_spi_resume':
> sound/soc/codecs/wm8711.c:558: error: dereferencing pointer to incomplete type
> sound/soc/codecs/wm8711.c: At top level:
> sound/soc/codecs/wm8711.c:565: error: variable 'wm8711_spi_driver' has initializer but incomplete type
> sound/soc/codecs/wm8711.c:566: error: unknown field 'driver' specified in initializer
> sound/soc/codecs/wm8711.c:566: error: extra brace group at end of initializer
> sound/soc/codecs/wm8711.c:566: error: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c:568: error: 'spi_bus_type' undeclared here (not in a function)
> sound/soc/codecs/wm8711.c:570: warning: excess elements in struct initializer
> sound/soc/codecs/wm8711.c:570: warning: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c:571: error: unknown field 'probe' specified in initializer
> sound/soc/codecs/wm8711.c:571: warning: excess elements in struct initializer
> sound/soc/codecs/wm8711.c:571: warning: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c:572: error: unknown field 'suspend' specified in initializer
> sound/soc/codecs/wm8711.c:572: warning: excess elements in struct initializer
> sound/soc/codecs/wm8711.c:572: warning: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c:573: error: unknown field 'resume' specified in initializer
> sound/soc/codecs/wm8711.c:573: warning: excess elements in struct initializer
> sound/soc/codecs/wm8711.c:573: warning: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c:574: error: unknown field 'remove' specified in initializer
> sound/soc/codecs/wm8711.c:574: warning: excess elements in struct initializer
> sound/soc/codecs/wm8711.c:574: warning: (near initialization for 'wm8711_spi_driver')
> sound/soc/codecs/wm8711.c: In function 'wm8711_modinit':
> sound/soc/codecs/wm8711.c:635: error: implicit declaration of function 'spi_register_driver'
> sound/soc/codecs/wm8711.c:635: error: 'wm8731_spi_driver' undeclared (first use in this function)
> sound/soc/codecs/wm8711.c:635: error: (Each undeclared identifier is reported only once
> sound/soc/codecs/wm8711.c:635: error: for each function it appears in.)
> sound/soc/codecs/wm8711.c: In function 'wm8711_exit':
> sound/soc/codecs/wm8711.c:651: error: implicit declaration of function 'spi_unregister_driver'
> sound/soc/codecs/wm8711.c:651: error: 'wm8731_spi_driver' undeclared (first use in this function)
> 
> Caused by commit 08aff8cd7a8568588d460c4bf8875a492d430314 ("ASoC: Add SPI
> support to WM8711").

I overlooked this since SPI was disabled on my test build.
Now fixed in sound git tree.


thanks,

Takashi

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

On Thu, 01 Oct 2009 08:45:40 +0200 Takashi Iwai <tiwai@suse.de> wrote:
> 
> I overlooked this since SPI was disabled on my test build.
> Now fixed in sound git tree.

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Hi Takashi,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_proc_write':
sound/core/oss/mixer_oss.c:1168: error: implicit declaration of function 'prinkt'
sound/core/seq/seq_device.c: In function 'snd_seq_device_register_driver':
sound/core/seq/seq_device.c:327: error: implicit declaration of function 'prinkt'

Caused by commit 36ce99c1dcab2978fc1900f19b431adedd8f99f6 ("ALSA: Add
debug module option").

I have used the version of the sound tree from next-20090827 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Fri, 28 Aug 2009 11:23:39 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
> 
> sound/core/oss/mixer_oss.c: In function 'snd_mixer_oss_proc_write':
> sound/core/oss/mixer_oss.c:1168: error: implicit declaration of function 'prinkt'
> sound/core/seq/seq_device.c: In function 'snd_seq_device_register_driver':
> sound/core/seq/seq_device.c:327: error: implicit declaration of function 'prinkt'
> 
> Caused by commit 36ce99c1dcab2978fc1900f19b431adedd8f99f6 ("ALSA: Add
> debug module option").
> 
> I have used the version of the sound tree from next-20090827 for today.

Fixed this typo now.  Sorry for inconvenience.


Takashi

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hi Takashi,

On Fri, 28 Aug 2009 07:37:31 +0200 Takashi Iwai <tiwai@suse.de> wrote:
>
> Fixed this typo now.  Sorry for inconvenience.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

Hi Takashi,

Today's linux-next build (x86_64 allmodconfig) failed like this:

sound/soc/codecs/ad1938.c: In function 'ad1938_spi_probe':
sound/soc/codecs/ad1938.c:423: error: 'struct device' has no member named 'driver_data'
sound/soc/codecs/ad1938.c: In function 'ad1938_spi_remove':
sound/soc/codecs/ad1938.c:430: error: 'struct device' has no member named 'driver_data'

Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
ad1938 codec driver based on asoc") interacting with commit
2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
tree (which will, I assume, be sent to Linus shortly - right, Greg?).

New drivers need to use the (existing) API's dev_{set,get}_drvdata().

I have used the version of the sound tree from next-20090716 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Greg KH]

On Fri, Jul 17, 2009 at 11:29:35AM +1000, Stephen Rothwell wrote:
> Hi Takashi,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_probe':
> sound/soc/codecs/ad1938.c:423: error: 'struct device' has no member named 'driver_data'
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_remove':
> sound/soc/codecs/ad1938.c:430: error: 'struct device' has no member named 'driver_data'
> 
> Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
> ad1938 codec driver based on asoc") interacting with commit
> 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
> dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
> tree (which will, I assume, be sent to Linus shortly - right, Greg?).

It turned out to be "too late" to make the change, I missed the -rc2
window, so it will be a .32 thing.

I'll move it from my driver-core.current to my driver-core tree to clear
up any confusion.

But yes, the apis should be used instead of directly accessing the
fields.

thanks,

greg k-h

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi Greg,

On Thu, 16 Jul 2009 21:56:20 -0700 Greg KH <greg@kroah.com> wrote:
>
> It turned out to be "too late" to make the change, I missed the -rc2
> window, so it will be a .32 thing.
> 
> I'll move it from my driver-core.current to my driver-core tree to clear
> up any confusion.

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Greg KH]

On Fri, Jul 17, 2009 at 03:32:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Thu, 16 Jul 2009 21:56:20 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > It turned out to be "too late" to make the change, I missed the -rc2
> > window, so it will be a .32 thing.
> > 
> > I'll move it from my driver-core.current to my driver-core tree to clear
> > up any confusion.
> 
> OK, thanks.

Now done.

thanks,

greg k-h

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Fri, 17 Jul 2009 11:29:35 +1000,
Stephen Rothwell wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi Takashi,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_probe':
> sound/soc/codecs/ad1938.c:423: error: 'struct device' has no member named 'driver_data'
> sound/soc/codecs/ad1938.c: In function 'ad1938_spi_remove':
> sound/soc/codecs/ad1938.c:430: error: 'struct device' has no member named 'driver_data'
> 
> Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
> ad1938 codec driver based on asoc") interacting with commit
> 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
> dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
> tree (which will, I assume, be sent to Linus shortly - right, Greg?).
> 
> New drivers need to use the (existing) API's dev_{set,get}_drvdata().

Yep.  Fixed now.


> I have used the version of the sound tree from next-20090716 for today.


thanks,

Takashi

Re: linux-next: sound tree build failure

[Mark Brown]

On Fri, Jul 17, 2009 at 11:29:35AM +1000, Stephen Rothwell wrote:

> Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
> ad1938 codec driver based on asoc") interacting with commit
> 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
> dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
> tree (which will, I assume, be sent to Linus shortly - right, Greg?).

I've fixed this.

> New drivers need to use the (existing) API's dev_{set,get}_drvdata().

Incidentally, is there any great reason not to have the equivalent thing
for platform data?  I can supply a patch.

>From 91a0351b2d1e86f421ee9c95d07136f648d2da06 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Fri, 17 Jul 2009 10:18:14 +0100
Subject: [PATCH] ASoC: Use driverdata accessors in ad1938

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/ad1938.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/ad1938.c b/sound/soc/codecs/ad1938.c
index 3dc8091..5a7d00c 100644
--- a/sound/soc/codecs/ad1938.c
+++ b/sound/soc/codecs/ad1938.c
@@ -420,14 +420,14 @@ static int __devinit ad1938_spi_probe(struct spi_device *spi)
 	codec->control_data = spi;
 	codec->dev = &spi->dev;
 
-	spi->dev.driver_data = ad1938;
+	dev_set_drvdata(&spi->dev, ad1938);
 
 	return ad1938_register(ad1938);
 }
 
 static int __devexit ad1938_spi_remove(struct spi_device *spi)
 {
-	struct ad1938_priv *ad1938 = spi->dev.driver_data;
+	struct ad1938_priv *ad1938 = dev_get_drvdata(&spi->dev);
 
 	ad1938_unregister(ad1938);
 	return 0;
-- 
1.6.3.3

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Fri, 17 Jul 2009 10:28:25 +0100,
Mark Brown wrote:
> 
> On Fri, Jul 17, 2009 at 11:29:35AM +1000, Stephen Rothwell wrote:
> 
> > Caused by commit 1274738d85d0e25c4f82d83f50a6bcbe2397e9ea ("ASoC: new
> > ad1938 codec driver based on asoc") interacting with commit
> > 2e34003ff6237e2216396d61dc8b32ea5959de80 ("Driver core: move
> > dev_get/set_drvdata to drivers/base/dd.c") from the driver-core.current
> > tree (which will, I assume, be sent to Linus shortly - right, Greg?).
> 
> I've fixed this.

Oh, it was already fixed this morning.
I couldn't send a notify mail just because my server crashed after
pushing the tree...   And rebooted now :)


Takashi

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Takashi,

Today's linux-next build (powerpc allyesconfig) failed like this:

sound/soc/codecs/twl4030.c: In function 'twl4030_read_reg_cache':
sound/soc/codecs/twl4030.c:152: error: 'cache' undeclared (first use in this function)

Caused by commit 16a30fbb0d3aa4ee829a2dd3d0e314e2b5ae96a9 ("ASoC:
TWL4030: Use reg_cache in twl4030_init_chip").

I reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Thu, 4 Jun 2009 17:33:42 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> sound/soc/codecs/twl4030.c: In function 'twl4030_read_reg_cache':
> sound/soc/codecs/twl4030.c:152: error: 'cache' undeclared (first use in this function)
> 
> Caused by commit 16a30fbb0d3aa4ee829a2dd3d0e314e2b5ae96a9 ("ASoC:
> TWL4030: Use reg_cache in twl4030_init_chip").
> 
> I reverted that commit for today.

Thanks.  It's likely a cut-and-paste error in that commit.
I fixed now on sound git tree.


Takashi

Re: linux-next: sound tree build failure

[Peter Ujfalusi]

On Thursday 04 June 2009 11:03:07 ext Takashi Iwai wrote:
> At Thu, 4 Jun 2009 17:33:42 +1000,
>
> Stephen Rothwell wrote:
> > Hi Takashi,
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> >
> > sound/soc/codecs/twl4030.c: In function 'twl4030_read_reg_cache':
> > sound/soc/codecs/twl4030.c:152: error: 'cache' undeclared (first use in
> > this function)
> >
> > Caused by commit 16a30fbb0d3aa4ee829a2dd3d0e314e2b5ae96a9 ("ASoC:
> > TWL4030: Use reg_cache in twl4030_init_chip").
> >
> > I reverted that commit for today.
>
> Thanks.  It's likely a cut-and-paste error in that commit.
> I fixed now on sound git tree.

Yes, it was a cut-and-paste error. I have also made the patch to fix it.
I'll not send it, thanks Takashi for fixing it.

It is so embarrassing, since this is the second time that my patch broke the 
linux-next build.
I'll try to be even more careful in the future.

Again, sorry about this.

>
> Takashi

-- 
Péter

Re: linux-next: sound tree build failure

[Mark Brown]

On Thu, Jun 04, 2009 at 10:03:07AM +0200, Takashi Iwai wrote:

> Thanks.  It's likely a cut-and-paste error in that commit.
> I fixed now on sound git tree.

Thanks for sorting this.

linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi Takashi,

Today's linux-next build (sparc64 allmodconfig) failed like this:

sound/pci/ctxfi/cthw20k2.c:1217:3: error: #error "Don't support 8k-page!"

Caused by commit 8cc72361481f00253f1e468ade5795427386d593 ("ALSA: SB X-Fi
driver merge").  I assume that this driver needs better Kconfig
protection.  Maybe test for CONFIG_SPARC64_PAGE_SIZE_8KB or something.
Does this driver support other pages sizes (16k, 64k, 256k)?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Thu, 21 May 2009 00:31:45 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> Today's linux-next build (sparc64 allmodconfig) failed like this:
> 
> sound/pci/ctxfi/cthw20k2.c:1217:3: error: #error "Don't support 8k-page!"
> 
> Caused by commit 8cc72361481f00253f1e468ade5795427386d593 ("ALSA: SB X-Fi
> driver merge").  I assume that this driver needs better Kconfig
> protection.  Maybe test for CONFIG_SPARC64_PAGE_SIZE_8KB or something.
> Does this driver support other pages sizes (16k, 64k, 256k)?

Likely not.  I'm going to fix and clean up the buffer handling of this
driver later, but first I need to get a hardware to test :)

Meanwhile, I'll add Kconfig dependency to x86 so that it won't be
built on other architectures (which haven't been tested anyway).


thanks,

Takashi

Re: linux-next: sound tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Hi Takashi,

On Wed, 20 May 2009 16:46:45 +0200 Takashi Iwai <tiwai@suse.de> wrote:
>
> Meanwhile, I'll add Kconfig dependency to x86 so that it won't be
> built on other architectures (which haven't been tested anyway).

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: sound tree build failure

[Takashi Iwai]

At Thu, 21 May 2009 00:59:49 +1000,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> On Wed, 20 May 2009 16:46:45 +0200 Takashi Iwai <tiwai@suse.de> wrote:
> >
> > Meanwhile, I'll add Kconfig dependency to x86 so that it won't be
> > built on other architectures (which haven't been tested anyway).
> 
> OK, thanks.

Fixed and pushed now.

Please pull the sound tree again if possible (or do it tomorrow :)


thanks,

Takashi