Re: [PATCH] Improve usability in case of init binary failure

[Andreas Mohr <andi@lisas.de>]

On Tue, Feb 02, 2010 at 09:20:41AM -0800, Andrew Morton wrote:
> On Mon, 1 Feb 2010 23:10:51 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
> 
> > On Sun, 27 Dec 2009, Andreas Mohr wrote:
> > 
> > > Well, took quite a while longer, partly due to broken Broadcom USB host
> > > (OpenWrt fix to be submitted) and non-working USB-audio on nicer platforms.
> > > 
> > > Took most of the comments into account (thanks!), improved some wording.
> > > 
> > > Patch against current git, compile- and runtime-tested,
> > > checkpatch.pl'd (with a single nice hierarchy warning resulting from mixing
> > > git diff output and manual /dev/null diffing).
> > > 
> > > Thanks!
> > > 
> > 
> > It looks like this patch got mangled when added to mmotm-2010-02-01-16-25 
> > in init-mainc-improve-usability-in-case-of-init-binary-failure.patch since 
> > it added init.txt to the root directory instead of Documentation,
> 
> ah, thanks.
> 
> > even though the patch below is correct.
> 
> Nope, the patch was wrong:
> 
> > > --- a/init/main.c
> > > +++ b/init/main.c
> > ...
> > > --- /dev/null	2009-12-27 16:25:29.521258205 +0100
> > > +++ Documentation/init.txt	2009-12-27 15:47:46.000000000 +0100
> 
> Should've been a/Documentation/init.txt

Indeed, which is why I had mentioned it in the submission (above),
but [fatally, as it turned out] did not bother to fix this ""minor"" issue.

Lots of sorries,

Andreas Mohr