From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bob Rodgers <Robert_Rodgers@dell.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
lenb@kernel.org, rpurdie@rpsys.net
Subject: Re: Re: [RFC] Dell activity led WMI driver
Date: Tue, 2 Feb 2010 17:53:42 -0800 [thread overview]
Message-ID: <20100203015341.GA21173@core.coreip.homeip.net> (raw)
In-Reply-To: <4B6898AF.5060703@dell.com>
Hi Bob,
On Tue, Feb 02, 2010 at 03:27:11PM -0600, Bob Rodgers wrote:
>
> static int __init dell_led_probe(struct platform_device *pdev)
> {
This should either be changed to __devinit or you need to call
platform_device_probe() or, even better, use platform_create_bundle()
that is in next.
But isn't it a bit wasteful to create a brand new platform device only
to attach a single led device to it? I think that, even thourgh LED GUID
is separate, it would be better to keep all this functionality in
dell-wmi driver.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-02-03 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 21:27 Re: [RFC] Dell activity led WMI driver Bob Rodgers
2010-02-03 1:53 ` Dmitry Torokhov [this message]
2010-02-03 10:10 ` Dan Carpenter
[not found] <4B6893A5.20509@dell.com>
2010-02-02 21:09 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203015341.GA21173@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Robert_Rodgers@dell.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).