[PATCH] tags: put function prototypes back!

[PATCH] tags: put function prototypes back!

[Alexey Dobriyan]

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file
claiming "It makes no real sense to include function prototypes".
But it is useful for quickly determining which header file developer
needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are
baggage), write a postprocessing script.

Please apply.

	Alexey, who is sick reverting this chunk locally.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 scripts/tags.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -108,7 +108,7 @@ exuberant()
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
-	--extra=+f --c-kinds=-px                                \
+	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
 

Re: [PATCH] tags: put function prototypes back!

[Uwe Kleine-König]

On Wed, Feb 03, 2010 at 10:18:17PM +0200, Alexey Dobriyan wrote:
> commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
> "ctags: usability fix" removed function prototypes from tags file
> claiming "It makes no real sense to include function prototypes".
> But it is useful for quickly determining which header file developer
> needs to include to fix compilation.
> 
> Now if someone wants to remove forward declatations (which I agree are
> baggage), write a postprocessing script.
> 
> Please apply.
> 
> 	Alexey, who is sick reverting this chunk locally.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] tags: put function prototypes back!

[Michal Marek]

On 15.6.2010 11:22, Uwe Kleine-König wrote:
> On Wed, Feb 03, 2010 at 10:18:17PM +0200, Alexey Dobriyan wrote:
>> commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
>> "ctags: usability fix" removed function prototypes from tags file
>> claiming "It makes no real sense to include function prototypes".
>> But it is useful for quickly determining which header file developer
>> needs to include to fix compilation.
>>
>> Now if someone wants to remove forward declatations (which I agree are
>> baggage), write a postprocessing script.
>>
>> Please apply.
>>
>> 	Alexey, who is sick reverting this chunk locally.
>>
>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Alexey, can you please resend the patch? I don't see it in the archives
anywhere.

Thanks,
Michal

Re: [PATCH] tags: put function prototypes back!

[Uwe Kleine-König]

On Tue, Jun 15, 2010 at 11:54:03AM +0200, Michal Marek wrote:
> On 15.6.2010 11:22, Uwe Kleine-König wrote:
> > On Wed, Feb 03, 2010 at 10:18:17PM +0200, Alexey Dobriyan wrote:
> >> commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
> >> "ctags: usability fix" removed function prototypes from tags file
> >> claiming "It makes no real sense to include function prototypes".
> >> But it is useful for quickly determining which header file developer
> >> needs to include to fix compilation.
> >>
> >> Now if someone wants to remove forward declatations (which I agree are
> >> baggage), write a postprocessing script.
> >>
> >> Please apply.
> >>
> >> 	Alexey, who is sick reverting this chunk locally.
> >>
> >> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Alexey, can you please resend the patch? I don't see it in the archives
> anywhere.

Gmane supports getting mails by Message-Id:

	http://mid.gmane.org/20100203201816.GA5987@x200

redirects to http://article.gmane.org/gmane.linux.kernel/946067,
appending raw is nearly suitable for usage by mutt.

{ echo From lala Mon Sep 17 00:00:00 2001; wget -O - http://article.gmane.org/gmane.linux.kernel/946067/raw; } > patch

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] tags: put function prototypes back!

[Michal Marek]

On 15.6.2010 13:41, Uwe Kleine-König wrote:
> On Tue, Jun 15, 2010 at 11:54:03AM +0200, Michal Marek wrote:
>> On 15.6.2010 11:22, Uwe Kleine-König wrote:
>>> On Wed, Feb 03, 2010 at 10:18:17PM +0200, Alexey Dobriyan wrote:
>>>> commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
>>>> "ctags: usability fix" removed function prototypes from tags file
>>>> claiming "It makes no real sense to include function prototypes".
>>>> But it is useful for quickly determining which header file developer
>>>> needs to include to fix compilation.
>>>>
>>>> Now if someone wants to remove forward declatations (which I agree are
>>>> baggage), write a postprocessing script.
>>>>
>>>> Please apply.
>>>>
>>>> 	Alexey, who is sick reverting this chunk locally.
>>>>
>>>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Alexey, can you please resend the patch? I don't see it in the archives
>> anywhere.
> 
> Gmane supports getting mails by Message-Id:
> 
> 	http://mid.gmane.org/20100203201816.GA5987@x200

Ah, thanks. I didn't notice that the original mail was from February.

Michal

[RESEND PATCH] tags: put function prototypes back!

[Uwe Kleine-König]

Commit 7db86dc (ctags: usability fix) removed function prototypes from
tags file claiming "It makes no real sense to include function
prototypes".
But it is useful for quickly determining which header file developer
needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are
baggage), write a postprocessing script.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 scripts/tags.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index 8509bb5..e091db3 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -123,7 +123,7 @@ exuberant()
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
-	--extra=+f --c-kinds=-px                                \
+	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
 
-- 
1.7.2.3

Re: [RESEND PATCH] tags: put function prototypes back!

[Uwe Kleine-König]

Hello Marek,

On Thu, Nov 04, 2010 at 10:24:16AM +0100, Uwe Kleine-König wrote:
> Commit 7db86dc (ctags: usability fix) removed function prototypes from
> tags file claiming "It makes no real sense to include function
> prototypes".
> But it is useful for quickly determining which header file developer
> needs to include to fix compilation.
> 
> Now if someone wants to remove forward declatations (which I agree are
> baggage), write a postprocessing script.
While sorting my pending patches I noticed that there's a typo, can you
please do s/declatations/declarations/ when taking the patch.
(Or tell me to resend an updated patch.)  (I'd say the sentence before
needs an "a" before developer, I'm not a native speaker though, so I
kept Alexey's wording.)

Best regards and thanks
Uwe 

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/tags.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 8509bb5..e091db3 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -123,7 +123,7 @@ exuberant()
>  	-I ____cacheline_internodealigned_in_smp                \
>  	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
>  	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
> -	--extra=+f --c-kinds=-px                                \
> +	--extra=+f --c-kinds=+px                                \
>  	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
>  	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
>  
> -- 
> 1.7.2.3
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [RESEND PATCH] tags: put function prototypes back!

[Michal Marek]

On Wed, Nov 17, 2010 at 10:06:54AM +0100, Uwe Kleine-König wrote:
> Hello Marek,
> 
> On Thu, Nov 04, 2010 at 10:24:16AM +0100, Uwe Kleine-König wrote:
> > Commit 7db86dc (ctags: usability fix) removed function prototypes from
> > tags file claiming "It makes no real sense to include function
> > prototypes".
> > But it is useful for quickly determining which header file developer
> > needs to include to fix compilation.
> > 
> > Now if someone wants to remove forward declatations (which I agree are
> > baggage), write a postprocessing script.

OK, I applied your patch to kbuild-2.6.git#misc. I initially though it
would be really nice to filter out forward declarations, but gave up on
this.

> While sorting my pending patches I noticed that there's a typo, can you
> please do s/declatations/declarations/ when taking the patch.

Done.

Michal