public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, x86 <x86@kernel.org>
Subject: mtrr/state.c unused?
Date: Wed, 3 Feb 2010 21:24:25 +0100	[thread overview]
Message-ID: <20100203202425.GC1367@aftab> (raw)

It looks like <arch/x86/kernel/cpu/mtrr/state.c> is not used by
anything in the kernel.

Besides cleanups, the only relevant patch in the git history is:

commit 2ec1df4130c60d1eb49dc0fa0ed15858fede6b05
Author: Thomas Gleixner <tglx@linutronix.de>
Date:   Thu Oct 11 11:16:28 2007 +0200

    i386: move kernel/cpu/mtrr


which adds it. Hmm...

A

git log -i --pickaxe-all -Sset_mtrr_prepare_save

for example, shows that

commit 9a6b344ea967efa0bb5ca4cb5405f840652b66c4
Author: Harvey Harrison <harvey.harrison@gmail.com>
Date:   Mon Feb 4 16:48:01 2008 +0100

    x86: remove long dead cyrix mtrr code

has removed the last callers of those helpers and they're now unused.
They should go if we don't need them anymore.

-- 
Regards/Gruss,
Boris.

--
Advanced Micro Devices, Inc.
Operating Systems Research Center

             reply	other threads:[~2010-02-03 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 20:24 Borislav Petkov [this message]
2010-02-04  8:24 ` mtrr/state.c unused? Ingo Molnar
2010-02-04  8:51   ` Borislav Petkov
2010-02-04  9:57     ` [tip:x86/cleanups] x86, mtrr: Remove unused mtrr/state.c tip-bot for Borislav Petkov
2010-02-04 17:29   ` mtrr/state.c unused? Harvey Harrison
2010-02-04 17:41     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100203202425.GC1367@aftab \
    --to=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox