* [PATCH] define percpu_counter_batch when CONFIG_SMP is not set
@ 2010-02-04 12:49 Nikanth Karthikesan
2010-02-04 12:58 ` Nikanth Karthikesan
0 siblings, 1 reply; 3+ messages in thread
From: Nikanth Karthikesan @ 2010-02-04 12:49 UTC (permalink / raw)
To: Tejun Heo; +Cc: Ingo Molnar, linux-kernel, Suresh Jayaraman
percpu_counter_batch is not defined if CONFIG_SMP is not set.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index a7684a5..ff57cef 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -83,6 +83,8 @@ struct percpu_counter {
s64 count;
};
+#define percpu_counter_batch 2
+
static inline int percpu_counter_init(struct percpu_counter *fbc, s64 amount)
{
fbc->count = amount;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] define percpu_counter_batch when CONFIG_SMP is not set
2010-02-04 12:49 [PATCH] define percpu_counter_batch when CONFIG_SMP is not set Nikanth Karthikesan
@ 2010-02-04 12:58 ` Nikanth Karthikesan
2010-02-04 15:03 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Nikanth Karthikesan @ 2010-02-04 12:58 UTC (permalink / raw)
To: Tejun Heo; +Cc: Ingo Molnar, linux-kernel, Suresh Jayaraman
On Thursday 04 February 2010 18:19:22 Nikanth Karthikesan wrote:
> percpu_counter_batch is not defined if CONFIG_SMP is not set.
The patch "sched: cpuacct: Use bigger percpu counter batch values for stats
counters" in tip (43f85eab1411905afe5db510fbf9841b516e7e6a) would fail to
build without this if CONFIG_SMP is not set.
Thanks
Nikanth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] define percpu_counter_batch when CONFIG_SMP is not set
2010-02-04 12:58 ` Nikanth Karthikesan
@ 2010-02-04 15:03 ` Peter Zijlstra
0 siblings, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2010-02-04 15:03 UTC (permalink / raw)
To: Nikanth Karthikesan
Cc: Tejun Heo, Ingo Molnar, linux-kernel, Suresh Jayaraman
On Thu, 2010-02-04 at 18:28 +0530, Nikanth Karthikesan wrote:
> On Thursday 04 February 2010 18:19:22 Nikanth Karthikesan wrote:
> > percpu_counter_batch is not defined if CONFIG_SMP is not set.
>
> The patch "sched: cpuacct: Use bigger percpu counter batch values for stats
> counters" in tip (43f85eab1411905afe5db510fbf9841b516e7e6a) would fail to
> build without this if CONFIG_SMP is not set.
Which is why it got reverted (e2dfc8a0356ee7e065bd5ec8a2ca0f9b61c2daef),
Anton also posted a new version that actually does build on UP.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-04 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-04 12:49 [PATCH] define percpu_counter_batch when CONFIG_SMP is not set Nikanth Karthikesan
2010-02-04 12:58 ` Nikanth Karthikesan
2010-02-04 15:03 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox