Re: Improving OOM killer

Lubos Lunak
2010-02-10T20:54:46Z

On Thursday 04 of February 2010, David Rientjes wrote:
> On Thu, 4 Feb 2010, Rik van Riel wrote:
> > The goal of the OOM killer is to kill some process, so the
> > system can continue running and automatically become available
> > again for whatever workload the system was running.
> >
> > Killing the parent process of one of the system daemons does
> > not achieve that goal, because you now caused a service to no
> > longer be available.
>
> The system daemon wouldn't be killed, though. You're right that this
> heuristic would prefer the system daemon slightly more as a result of the
> forkbomb penalty, but the oom killer always attempts to sacrifice a child
> with a seperate mm before killing the selected task. Since the forkbomb
> heuristic only adds up those children with seperate mms, we're guaranteed
> to not kill the daemon itself.

Which however can mean that not killing this system daemon will be traded for
DoS-ing the whole system, if the daemon keeps spawning new children as soon
as the OOM killer frees up resources for them.

This looks like wrong solution to me, it's like trying to save a target by
shooting all incoming bombs instead of shooting the bomber. If the OOM
situation is caused by one or a limited number of its children, or if the
system daemon is not reponsible for the forkbomb (e.g. it's only a subtree of
its children), then it won't be selected for killing anyway. If it is
responsible for the forkbomb, the OOM killer can trying killing the bombs
forever to no avail.

--
Lubos Lunak
openSUSE Boosters team, KDE developer
l.lunak@suse.cz , l.lunak@kde.org