linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tejun Heo <tj@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linus <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Lameter <cl@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Fr??d??ric Weisbecker <fweisbec@gmail.com>
Subject: Re: upcoming percpu changes
Date: Fri, 5 Feb 2010 08:09:03 +0100	[thread overview]
Message-ID: <20100205070903.GA9320@elte.hu> (raw)
In-Reply-To: <4B6BB13C.2090108@kernel.org>


* Tejun Heo <tj@kernel.org> wrote:

> Hello,
> 
> On 02/05/2010 02:16 PM, Stephen Rothwell wrote:
> > The percpu tree currently in linux-next
> > (git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git#for-next)
> > contains a patch to remove the "per_cpu_" prefix from percpu variables
> > followed by  a set of patches to annotate all the percpu variables (and
> > accessing variables) with a __percpu tag to put them into a separate
> > sparse name space.  These latter patches are causing some merge conflicts
> > with a couple of trees (and will most likely cause more before the merge
> > window).  A solution to this is for you to accept the patch below into
> > your tree now and then the annotating patches can be sent to the
> > respective maintainers directly.
> > 
> > Of course, this assumes that you will accept the percpu changes during
> > the next merge window (and they are not completely without controversy)
> > and the proponents actually submit them :-).
> > 
> > What do you think?
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Fri, 5 Feb 2010 16:09:11 +1100
> > Subject: [PATCH] percpu: add __percpu for sparse
> > 
> > This is to make the annotation of percpu variables during the next merge
> > window less painfull.
> > 
> > Extracted from a patch by Rusty Russell.
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> I agree that this would be the cleanest way to integrate things.
> Thanks for doing this.  If this gets in, I'll send individual patches
> to respective maintainers.
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> For reference, the thread which contains the annoation patches is
> 
>   http://lkml.org/lkml/2010/1/25/107
> 
> Thanks.

Has the review feedback from Frederic and hpa been addressed? (and have they 
acked the solution?) That was the only controversial bit i remember.

Thanks,

	Ingo

  reply	other threads:[~2010-02-05  7:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-05  5:16 upcoming percpu changes Stephen Rothwell
2010-02-05  5:48 ` Tejun Heo
2010-02-05  7:09   ` Ingo Molnar [this message]
2010-02-05  7:31     ` Tejun Heo
2010-02-05  7:29       ` Ingo Molnar
2010-02-12  8:21 ` Tejun Heo
2010-02-12 11:10   ` Stephen Rothwell
2010-02-12 13:23     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100205070903.GA9320@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sfr@canb.auug.org.au \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).