* [PATCH 2/2] Staging: samsung-laptop: fix coding style issues
@ 2010-02-05 5:11 Chihau Chau
2010-02-05 17:14 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Chihau Chau @ 2010-02-05 5:11 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Chihau Chau
From: Chihau Chau <chihau@gmail.com>
This fixes some lines over 80 characters coding style issues
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
drivers/staging/samsung-laptop/samsung-laptop.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c
index 4877138..87ec773 100644
--- a/drivers/staging/samsung-laptop/samsung-laptop.c
+++ b/drivers/staging/samsung-laptop/samsung-laptop.c
@@ -99,7 +99,8 @@ static struct rfkill *rfk;
static int force;
module_param(force, bool, 0);
-MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be loaded");
+MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be "
+ "loaded");
static int debug;
module_param(debug, bool, S_IRUGO | S_IWUSR);
@@ -370,7 +371,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
{
.ident = "N128",
.matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_SYS_VENDOR,
+ "SAMSUNG ELECTRONICS CO., LTD."),
DMI_MATCH(DMI_PRODUCT_NAME, "N128"),
DMI_MATCH(DMI_BOARD_NAME, "N128"),
},
@@ -379,7 +381,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
{
.ident = "N130",
.matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_SYS_VENDOR,
+ "SAMSUNG ELECTRONICS CO., LTD."),
DMI_MATCH(DMI_PRODUCT_NAME, "N130"),
DMI_MATCH(DMI_BOARD_NAME, "N130"),
},
--
1.5.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] Staging: samsung-laptop: fix coding style issues
2010-02-05 5:11 [PATCH 2/2] Staging: samsung-laptop: fix coding style issues Chihau Chau
@ 2010-02-05 17:14 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2010-02-05 17:14 UTC (permalink / raw)
To: Chihau Chau; +Cc: devel, linux-kernel
On Fri, Feb 05, 2010 at 02:11:48AM -0300, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some lines over 80 characters coding style issues
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
> ---
> drivers/staging/samsung-laptop/samsung-laptop.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c
> index 4877138..87ec773 100644
> --- a/drivers/staging/samsung-laptop/samsung-laptop.c
> +++ b/drivers/staging/samsung-laptop/samsung-laptop.c
> @@ -99,7 +99,8 @@ static struct rfkill *rfk;
>
> static int force;
> module_param(force, bool, 0);
> -MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be loaded");
> +MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be "
> + "loaded");
Um, care to move the whole string down one line to make it nicer to look
at?
> static int debug;
> module_param(debug, bool, S_IRUGO | S_IWUSR);
> @@ -370,7 +371,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
> {
> .ident = "N128",
> .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + DMI_MATCH(DMI_SYS_VENDOR,
> + "SAMSUNG ELECTRONICS CO., LTD."),
Like this, what you did here was fine, can you do this above as well and
resubmit the whole thing to me so I can apply it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] Staging: samsung-laptop: fix coding style issues
@ 2010-02-05 18:23 Chihau Chau
0 siblings, 0 replies; 3+ messages in thread
From: Chihau Chau @ 2010-02-05 18:23 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Chihau Chau
From: Chihau Chau <chihau@gmail.com>
This is the new version of the patch, I have solved your correction.
This fixes some lines over 80 characters coding style issues.
Thanks! Greg.
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
drivers/staging/samsung-laptop/samsung-laptop.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c
index 4877138..8019044 100644
--- a/drivers/staging/samsung-laptop/samsung-laptop.c
+++ b/drivers/staging/samsung-laptop/samsung-laptop.c
@@ -99,7 +99,8 @@ static struct rfkill *rfk;
static int force;
module_param(force, bool, 0);
-MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be loaded");
+MODULE_PARM_DESC(force,
+ "Disable the DMI check and forces the driver to be loaded");
static int debug;
module_param(debug, bool, S_IRUGO | S_IWUSR);
@@ -370,7 +371,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
{
.ident = "N128",
.matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_SYS_VENDOR,
+ "SAMSUNG ELECTRONICS CO., LTD."),
DMI_MATCH(DMI_PRODUCT_NAME, "N128"),
DMI_MATCH(DMI_BOARD_NAME, "N128"),
},
@@ -379,7 +381,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
{
.ident = "N130",
.matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_SYS_VENDOR,
+ "SAMSUNG ELECTRONICS CO., LTD."),
DMI_MATCH(DMI_PRODUCT_NAME, "N130"),
DMI_MATCH(DMI_BOARD_NAME, "N130"),
},
--
1.5.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-05 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-05 5:11 [PATCH 2/2] Staging: samsung-laptop: fix coding style issues Chihau Chau
2010-02-05 17:14 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-02-05 18:23 Chihau Chau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).