public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: wzt wzt <wzt.wzt@gmail.com>
Cc: linux-kernel@vger.kernel.org, sds@tycho.nsa.gov,
	jmorris@namei.org, eparis@parisplace.org
Subject: Re: [PATCH] LSM: add static to security_ops variable
Date: Sun, 7 Feb 2010 06:14:45 -0800	[thread overview]
Message-ID: <20100207141445.GA19744@kroah.com> (raw)
In-Reply-To: <628d1651002070324w424012eanda9392db26331905@mail.gmail.com>

On Sun, Feb 07, 2010 at 07:24:44PM +0800, wzt wzt wrote:
> security_ops was declared as a global variable, so other drivers or
> kernel code can easily change its value, like:
> 
> extern struct security_operations *security_ops;
> security_ops = NULL;
> 
> then insmod this driver immediately, it will get an oops.  Other evil
> drivers can aslo fake this variable as extern.

Evil drivers can do lots of things, if you can load a kernel module on
the system, all bets are off.  Just making this a private variable does
not mean much.

What external module are you trying to keep from using this variable?

thanks,

greg k-h

  reply	other threads:[~2010-02-07 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 11:24 [PATCH] LSM: add static to security_ops variable wzt wzt
2010-02-07 14:14 ` Greg KH [this message]
2010-02-16 14:57 ` Stephen Smalley
2010-02-19 11:40   ` wzt wzt
2010-02-19 13:47     ` Stephen Smalley
2010-02-19 11:44 ` Alexey Dobriyan
2010-02-19 11:57   ` wzt wzt
2010-02-19 12:02     ` Alexey Dobriyan
2010-02-19 12:23       ` wzt wzt
2010-02-19 12:27         ` Alexey Dobriyan
2010-02-19 13:14           ` wzt wzt
2010-02-19 13:12         ` Bernd Petrovitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100207141445.GA19744@kroah.com \
    --to=greg@kroah.com \
    --cc=eparis@parisplace.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=wzt.wzt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox