From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org,
kyungmin.park@samsung.com
Subject: Re: [PATCH] regulator: Add enable_time on probe of WM8994
Date: Sun, 7 Feb 2010 23:56:50 +0000 [thread overview]
Message-ID: <20100207235650.GA14408@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4B6E0C36.3090608@samsung.com>
On Sun, Feb 07, 2010 at 09:41:26AM +0900, Joonyoung Shim wrote:
> WM8994 regulator needs some delay to enable when it is probed too.
What is the problem that's fixed by this change?
The only case I can think of where it would help is if the regulator
constraints are used to enable the regulators and run them at a
non-default voltage. (which is not a recommended configuration since
this would mean raising the voltage and therefore increasing power
consumption). For that case this is not quite enough of a change since
the LDO that is being controlled may not be the one that brings the
device out of power on reset. More extensive rearrangement of the core
regulator code would be required to deal with that, reordering the
application of constraints.
next prev parent reply other threads:[~2010-02-07 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 0:41 [PATCH] regulator: Add enable_time on probe of WM8994 Joonyoung Shim
2010-02-07 23:56 ` Mark Brown [this message]
2010-02-08 6:03 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100207235650.GA14408@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox