From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jason Baron <jbaron@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
lizf@cn.fujitsu.com, rostedt@goodmis.org, fweisbec@gmail.com,
mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de,
mhiramat@redhat.com
Subject: Re: [PATCH 5/6] syscalls: add define syscall prefix macro
Date: Mon, 8 Feb 2010 21:48:16 +0100 [thread overview]
Message-ID: <201002082148.16556.arnd@arndb.de> (raw)
In-Reply-To: <20100208175407.GA14187@infradead.org>
On Monday 08 February 2010 18:54:07 Christoph Hellwig wrote:
> On Mon, Feb 08, 2010 at 05:12:36PM +0100, Arnd Bergmann wrote:
> > On Monday 08 February 2010, Jason Baron wrote:
> > > So I was trying to keep the names of the arch ia32 compat sys calls the
> > > same, ie 'sys32_blah'. However, I agree a common naming scheme makes
> > > more sense. what about 'arch_compat_sys_blah'? So as to distinguish from
> > > the common compat syscalls 'compat_sys_blah'.
> >
> > Why do you need to distinguish them? I would hope that we never need to
> > have a kernel with both a generic and an arch specific compat version
> > of the same syscall.
>
> Well, the usual alignment or number of arguments issues could lead to
> just that. We should deal with it the same way as for native syscalls.
Ah, right. The arch specific syscall may just be a wrapper calling the
generic function, so we need them both.
Arnd
next prev parent reply other threads:[~2010-02-08 20:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 21:21 [PATCH 0/6] tracing: add compat syscall support Jason Baron
2010-02-02 21:21 ` [PATCH 1/6] x86: add NR_syscalls_compat, make ia32 syscall table visible Jason Baron
2010-02-02 21:21 ` [PATCH 2/6] x86: add arch_compat_syscall_addr() Jason Baron
2010-02-02 21:21 ` [PATCH 3/6] tracing: remove syscall bitmaps in preparation for compat support Jason Baron
2010-02-02 21:21 ` [PATCH 4/6] tracing: add tracing support for compat syscalls Jason Baron
2010-02-03 12:52 ` Heiko Carstens
2010-02-08 15:43 ` Jason Baron
2010-02-08 16:34 ` Heiko Carstens
2010-02-09 10:21 ` Heiko Carstens
2010-02-09 14:54 ` Jason Baron
2010-02-02 21:21 ` [PATCH 5/6] syscalls: add define syscall prefix macro Jason Baron
2010-02-03 13:01 ` Heiko Carstens
2010-02-08 15:48 ` Jason Baron
2010-02-08 16:12 ` Arnd Bergmann
2010-02-08 17:54 ` Christoph Hellwig
2010-02-08 20:48 ` Arnd Bergmann [this message]
2010-02-08 16:53 ` Randy Dunlap
2010-02-08 17:11 ` Jason Baron
2010-02-10 3:00 ` Steven Rostedt
2010-02-02 21:22 ` [PATCH 6/6] x86: convert compat syscalls to use 'DEFINE_SYSCALL()' macros Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002082148.16556.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox