From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] allow printk delay after multi lines
Date: Mon, 8 Feb 2010 22:07:53 -0800 [thread overview]
Message-ID: <20100208220753.61a39bab.akpm@linux-foundation.org> (raw)
In-Reply-To: <a8e1da1002082156s3145a775o7424bc47ac503636@mail.gmail.com>
On Tue, 9 Feb 2010 13:56:34 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> BTW, for the sysctl variables. I found in kernel.h there's:
> printk/console_loglevel/panic related extern variables for sysctl.
>
> console_loglevel and panic related variables are used here and there,
> not just for sysctl, so I think it should stay in kernel.h.
>
> The printk related variables for sysctl and all the extern variables in
> sysctl.c can be move to sysctl.h. Seems no need new head file.
>
> Andrew, what's your opinion?
Symbols which are defined in printk.c and which are used in other
compilation units should be declared in printk.h!
We mucked up in the past by putting these things in kernel.h and as
externs in sysctl.c, but that's no reason to continue to do so. As a
special-case, it makes convenience sense to declare printk() itself and
the loglevel strings etc in kernel.h, but that _is_ a special case.
next prev parent reply other threads:[~2010-02-09 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 13:40 [PATCH 2/2] allow printk delay after multi lines Dave Young
2010-02-08 21:56 ` Andrew Morton
2010-02-08 22:01 ` Andrew Morton
2010-02-09 2:35 ` Dave Young
2010-02-09 2:31 ` Dave Young
2010-02-09 5:56 ` Dave Young
2010-02-09 6:07 ` Andrew Morton [this message]
2010-02-09 6:27 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208220753.61a39bab.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox