From: Greg KH <gregkh@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, linux-usb@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: don't read past config->interface[] if usb_control_msg() fails in usb_reset_configuration()
Date: Tue, 9 Feb 2010 05:08:04 -0800 [thread overview]
Message-ID: <20100209130804.GB30014@suse.de> (raw)
In-Reply-To: <4B715C55.5090102@gmail.com>
On Tue, Feb 09, 2010 at 02:00:05PM +0100, Roel Kluin wrote:
> After the loop `for (i = 0; i < config->desc.bNumInterfaces; i++)' if no
> break occurred, i equals config->desc.bNumInterfaces. so if
> usb_control_msg() failed then after goto reset_old_alts we read from
> config->interface[config->desc.bNumInterfaces].
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Have you seen this happen on real hardware?
curious,
greg k-h
next prev parent reply other threads:[~2010-02-09 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 13:00 [PATCH] USB: don't read past config->interface[] if usb_control_msg() fails in usb_reset_configuration() Roel Kluin
2010-02-09 13:08 ` Greg KH [this message]
2010-02-09 13:15 ` roel kluin
2010-02-09 15:12 ` Alan Stern
2010-02-09 16:01 ` Roel Kluin
2010-02-09 22:01 ` Sarah Sharp
2010-02-09 22:09 ` roel kluin
2010-02-17 23:40 ` Greg KH
2010-02-18 1:36 ` Roel Kluin
2010-02-09 22:01 ` Roel Kluin
2010-02-09 22:52 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209130804.GB30014@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox