From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless-2.6 2010-02-10
Date: Wed, 10 Feb 2010 11:07:56 -0800 (PST) [thread overview]
Message-ID: <20100210.110756.201335073.davem@davemloft.net> (raw)
In-Reply-To: <20100210185816.GB3286@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Wed, 10 Feb 2010 13:58:16 -0500
> Please let me know if there are problems!
I see one:
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 5681ebe..03dfd27 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -494,8 +494,7 @@ static int ssb_devices_register(struct ssb_bus *bus)
> #endif
> break;
> case SSB_BUSTYPE_SDIO:
> -#ifdef CONFIG_SSB_SDIO
> - sdev->irq = bus->host_sdio->dev.irq;
> +#ifdef CONFIG_SSB_SDIOHOST
> dev->parent = &bus->host_sdio->dev;
> #endif
> break;
The commit message says "fix a typo" but it's also removing
the assignment of sdev->irq
All the bus types assign the sdev->irq, so it looks like
this was removed unintentionally.
If it was intentional, it needs to be explained in the
commit message or a code comment.
next prev parent reply other threads:[~2010-02-10 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 18:58 pull request: wireless-2.6 2010-02-10 John W. Linville
2010-02-10 19:07 ` David Miller [this message]
2010-02-10 19:15 ` Johannes Berg
2010-02-10 19:36 ` David Miller
2010-02-10 20:19 ` John W. Linville
2010-02-10 20:25 ` David Miller
2010-02-10 20:32 ` John W. Linville
2010-02-10 20:35 ` David Miller
2010-02-10 20:37 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210.110756.201335073.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox