From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756071Ab0BJU3f (ORCPT ); Wed, 10 Feb 2010 15:29:35 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:55378 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755892Ab0BJU3d (ORCPT ); Wed, 10 Feb 2010 15:29:33 -0500 Date: Wed, 10 Feb 2010 12:29:47 -0800 (PST) Message-Id: <20100210.122947.171052717.davem@davemloft.net> To: lizf@cn.fujitsu.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 00/13] net: simplify seq_file code, revised From: David Miller In-Reply-To: <20100210.113115.28754681.davem@davemloft.net> References: <4B712849.9040400@cn.fujitsu.com> <20100210.113115.28754681.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Date: Wed, 10 Feb 2010 11:31:15 -0800 (PST) > From: Li Zefan > Date: Tue, 09 Feb 2010 17:18:01 +0800 > >> This patchset introduces seq_hlist_foo() helpers, and convert >> net/* to seq_hlist_foo() and seq_list_foo(). >> >> Changelog: >> >> - Add kerneldoc in patch 1/13 >> - Fix compile warning in patch 11/13 >> - Fix a bug in patch 12/13 > > All applied to net-next-2.6, thanks! You did not build test your changes. net/irda/irlan/irlan_common.c:1156: error: 'struct irlan_cb' has no member named 'list' net/irda/irlan/irlan_common.c:1156: warning: type defaults to 'int' in declaration of '__mptr' net/irda/irlan/irlan_common.c:1156: error: 'struct irlan_cb' has no member named 'list' I'll fix this, but I will not next time. Instead, I'll revert all of your changes and push it back to you. Thanks.