public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org,
	Mocean Laboratories <info@mocean-labs.com>,
	Juergen Beisert <j.beisert@pengutronix.de>,
	Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: mmotm 2010-02-10-16-17 uploaded (timberdale)
Date: Thu, 11 Feb 2010 14:01:17 -0800	[thread overview]
Message-ID: <20100211140117.455dbbff.akpm@linux-foundation.org> (raw)
In-Reply-To: <4B736ED5.5060205@oracle.com>

On Wed, 10 Feb 2010 18:43:33 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On 02/10/10 16:17, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2010-02-10-16-17 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://zen-kernel.org/kernel/mmotm.git
> > 
> > It contains the following patches against 2.6.33-rc7:
> 
> 
> When CONFIG_GPIOLIB is not enabled:
> 
>   CC      drivers/mfd/timberdale.o
> In file included from mmotm-2010-0210-1617/drivers/mfd/timberdale.c:37:
> mmotm-2010-0210-1617/include/linux/spi/max7301.h:14: error: field 'chip' has incomplete type
> make[3]: *** [drivers/mfd/timberdale.o] Error 1
> 
> 
> Build error observed on i386 and on x86_64.
> 

Bug is in mainline too, I think.

Something like this?

--- a/drivers/gpio/Kconfig~drivers-gpio-max7301c-depends-on-gpiolib
+++ a/drivers/gpio/Kconfig
@@ -92,7 +92,7 @@ comment "I2C GPIO expanders:"
 
 config GPIO_MAX7300
 	tristate "Maxim MAX7300 GPIO expander"
-	depends on I2C
+	depends on I2C && GPIOLIB
 	select GPIO_MAX730X
 	help
 	  GPIO driver for Maxim MAX7301 I2C-based GPIO expander.
_


  reply	other threads:[~2010-02-11 22:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11  0:17 mmotm 2010-02-10-16-17 uploaded akpm
2010-02-11  2:43 ` mmotm 2010-02-10-16-17 uploaded (timberdale) Randy Dunlap
2010-02-11 22:01   ` Andrew Morton [this message]
2010-02-11 22:18     ` Randy Dunlap
2010-02-11 22:36       ` Andrew Morton
2010-02-11 23:30         ` [PATCH -mmotm] timberdale: fix mfd build Randy Dunlap
2010-02-11  5:11 ` mmotm 2010-02-10 - lockdep whinge in ACPI code Valdis.Kletnieks
2010-02-11  5:26   ` Andrew Morton
2010-02-11 15:01     ` Greg KH
2010-02-12  2:11     ` Dave Young
2010-02-12  2:44 ` mmotm 2010-02-10 - BUG at fs/dcache.c:677! Valdis.Kletnieks
2010-02-12  3:14   ` Andrew Morton
2010-02-12  4:51     ` Jun'ichi Nomura
2010-02-12  5:01       ` Al Viro
2010-02-12  5:07         ` Al Viro
2010-02-12  5:30       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100211140117.455dbbff.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=g.liakhovetski@pengutronix.de \
    --cc=info@mocean-labs.com \
    --cc=j.beisert@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox