Re: oops in uevent_helper [was: mmotm 2010-01-13-12-17 uploaded]

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 11 Feb 2010 21:57:45 +0100
Andi Kleen <andi@firstfloor.org> wrote:

> On Wed, Feb 10, 2010 at 08:54:11PM +0100, Jiri Slaby wrote:
> > On 01/23/2010 12:52 AM, Andrew Morton wrote:
> > > On Sat, 16 Jan 2010 00:38:32 +0100
> > > Jiri Slaby <jirislaby@gmail.com> wrote:
> > > 
> > >> (fixed subject)
> > >>
> > >> On 01/15/2010 08:33 PM, Jiri Slaby wrote:
> > >>> On 01/13/2010 09:17 PM, akpm@linux-foundation.org wrote:
> > >>>> The mm-of-the-moment snapshot 2010-01-13-12-17 has been uploaded to
> > >>>
> > >>> Hi, it crashes on my machine while booting up. It is a regression
> > >>> against 2010-01-06-14-34. Doesn't it ring a bell by a chance?
> > >>
> > >> Well, memcpying to something like this:
> > >> char *uevent_helper = CONFIG_UEVENT_HELPER_PATH;
> > >> doesn't sound like a good idea :).
> > >>
> > >> And it's racy with sysctl path anyway.
> > >>
> > >> Looks like added by:
> > >> sysctl-convert-hotplug-helper-string-to-proc_rcu_string.patch
> > 
> > Ping Andi.
> 
> Sorry, busy with other stuff right now. There was at least one
> other unsolved problem in this patch series. I'll try to look
> at it on the weekend.
> 
> Andrew, it's ok for me if you just drop the series for now;
> I'll resubmit.

urgh, must I?  That trashes Neil's
kmod-add-init-function-to-usermodehelper.patch and
kmod-replace-call_usermodehelper_pipe-with-use-of-umh-init-function-and-resolve-limit.patch
and probably requires repairing other stuff and sets the testing status
back to "square one".

If you have patches queued, please make the time to support them!