From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Bob Rodgers <Robert_Rodgers@dell.com>,
"lenb@kernel.org" <lenb@kernel.org>,
Linux-kernel <linux-kernel@vger.kernel.org>,
Louis Davis <Louis_Davis@dell.com>,
Jim Dailey <Jim_Dailey@dell.com>,
Michael Brown <Michael_E_Brown@dell.com>,
Mario Limonciello <Mario_Limonciello@dell.com>,
Matt Domsch <Matt_Domsch@dell.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] Add Dell Business Class Netbook LED driver
Date: Thu, 11 Feb 2010 10:28:30 -0800 [thread overview]
Message-ID: <20100211182829.GA26659@core.coreip.homeip.net> (raw)
In-Reply-To: <20100211180715.GA2147@srcf.ucam.org>
On Thu, Feb 11, 2010 at 06:07:15PM +0000, Matthew Garrett wrote:
> On Thu, Feb 11, 2010 at 10:05:19AM -0800, Dmitry Torokhov wrote:
>
> > Or stuck it in dell-wmi.c...
>
> I'd prefer not to put it in dell-wmi. There's no logical association
> between it and the rest of the code there, so it'd just be overhead on
> the majority of systems. With the exception of cases where the event and
> functional interfaces are different GUIDs, I'd prefer a one GUID per
> driver model.
>
This is an opposite direction form the rest of the platform drivers
which tend to combine functionality on per-vendor basis in one driver.
I'd say that in this case with this LED driver overhead on DELL systems
not supportinfg it is miniscule. The benefit is that all vendor-specific
sub-devices are children of one parent platform device.
--
Dmitry
next prev parent reply other threads:[~2010-02-11 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 20:49 [PATCH] Add Dell Business Class Netbook LED driver Bob Rodgers
2010-02-11 17:59 ` Richard Purdie
2010-02-11 18:05 ` Dmitry Torokhov
2010-02-11 18:07 ` Matthew Garrett
2010-02-11 18:28 ` Dmitry Torokhov [this message]
2010-02-11 18:31 ` Matthew Garrett
2010-02-11 18:09 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100211182829.GA26659@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Jim_Dailey@dell.com \
--cc=Louis_Davis@dell.com \
--cc=Mario_Limonciello@dell.com \
--cc=Matt_Domsch@dell.com \
--cc=Michael_E_Brown@dell.com \
--cc=Robert_Rodgers@dell.com \
--cc=error27@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox