Re: [PATCH] isl29003: Move from misc to als now it available with minimal changes

[Daniel Mack <daniel@caiaq.de>]

Hi Jonathan,

On Sat, Dec 12, 2009 at 06:00:51PM +0000, Jonathan Cameron wrote:
>  I originally offered to move this to IIO, but ALS is more appropriate.
>  There are a couple of attibutes in here that don't correspond directly
>  to any currently in ALS. Feel free to offer suggestions for renames etc
>  on these, but I'd prefer to see them in a second patch allowing us to
>  keep things in this movement patch nice and clean. Will do api help
>  once these are pinned down.

Thanks again for doing this. I gave that ported driver a quick test and
it seems to work fine. Just one thing below ...

> diff --git a/drivers/misc/isl29003.c b/drivers/als/isl29003.c
> similarity index 90%
> rename from drivers/misc/isl29003.c
> rename to drivers/als/isl29003.c
> index a71e245..2ab188e 100644
> --- a/drivers/misc/isl29003.c
> +++ b/drivers/als/isl29003.c
> @@ -31,9 +31,10 @@
>  #include <linux/i2c.h>
>  #include <linux/mutex.h>
>  #include <linux/delay.h>
> +#include <linux/als_sys.h>

You need linux/err.h here. Without that, it breaks at compile time on a
PXA board as 'PTR_ERR' and 'IS_ERR' are undefined.

Apart from that:

Acked-by: Daniel Mack <daniel@caiaq.de>