public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-sh@vger.kernel.org, linux-parisc@vger.kernel.org,
	sparclinux@vger.kernel.org
Cc: Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org
Subject: parsic/sh/sparc tracehook breakage when tracing signals
Date: Thu, 11 Feb 2010 19:10:47 -0500	[thread overview]
Message-ID: <201002111910.50596.vapier@gentoo.org> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 933 bytes --]

when i ported the Blackfin code to the tracehook framework, i copied a latent 
bug from the sparc port.  trying to trace another process while handling 
signals no longer worked (and subsequently broke some of the gdb tests).

this was due to calling tracehook_signal_handler() with the last argument 
(stepping) always as 0.  if we look at the definition of this function in 
linux/tracehook.h, we see that calling the function stepping=0 is pointless:
	if (stepping)
		ptrace_notify(SIGTRAP);

after Roland pointed out some more stuff, i went back and looked at all the 
tracehook arches in the tree.  it seems like these arches are all broken in 
the same way:
	parisc (arch/parisc/kernel/signal.c)
	SuperH (64bit only) (arch/sh/kernel/signal_64.c)
	Sparc (all bits) (arch/sparc/kernel/signal{_32,32,_64}.c)

seems like you guys should just change the last argument to:
	test_thread_flag(TIF_SINGLESTEP)
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2010-02-12  0:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-12  0:10 Mike Frysinger [this message]
2010-02-12  0:39 ` parsic/sh/sparc tracehook breakage when tracing signals David Miller
2010-02-12  0:56   ` Mike Frysinger
2010-02-12  3:07 ` Roland McGrath
2010-02-12 15:09 ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002111910.50596.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox